Joi: Invalid regex for Joi.string().email()

[ghost]

Context

• node version: v8.6.0
• joi version: 13.0.2
• environment (node, browser): node
• used with (hapi, standalone, ...): standalone
• any other relevant information:

What are you trying to achieve or the steps to reproduce ?

I tried using "email@nodomain" as an email, which should be rejected due to invalid email format. But, is accepting the input.

Describe your issue here, include schemas and inputs you are validating if needed.

const schema = Joi.object().keys({
    email: Joi.string().email().required(),
});

Which result you had ?

On trying "email@nodomain" accepts the string input as an email. Whereas it must reject it since the domain is invalid.

What did you expect ?

The correct regex for email must be

/^([a-zA-Z0-9_-.]+)@([a-zA-Z0-9_-.]+).([a-zA-Z]{2,5})$ /

This would allow only "[email protected]" or such type of strings to pass as email.

[Marsup]

Nope, it's a valid email. Read the options and search issues about minDomainAtoms.

[RaghuVarmaPinnelli]

The above issue is still not fixed on [email protected], could this be fixed with correct regex in any of the versions coming up

[Marsup]

Have you at least read the response I gave ?

[heylookalive]

I can understand in a way regarding minDomainAtoms but would it not be more sensible to cater to the majority of use cases where we'd expect this by default to be set to 2?

[WesTyler]

But isemail isn't about catering to specific use-cases. It is geared toward following the RFCs that dictate what is and isn't a valid email. So the defaults are to follow the RFCs as closely as possible. Options like minDomainAtoms are added on top of the RFCs to allow people to limit emails to be more restrictive than RFC.

[heylookalive]

Hmm I agree, think I'm coming from the angle of it not being super obvious at a glance and a documentation tweak should hopefully prevent some confusion.

I've submitted a PR for an update to the README.md