Jkube: ExternalCommand.java: Change the visibility of constructor to "protected"

Created on 23 Jul 2021 · 1Comment · Source: eclipse/jkube

Description

The following statement is reported as a code smell by SonarCloud:

https://github.com/eclipse/jkube/blob/5c745b9e8dd85d3a6889816c0e316078d34c6691/jkube-kit/common/src/main/java/org/eclipse/jkube/kit/common/ExternalCommand.java#L43

It should be replaced by the following:

    protected ExternalCommand(KitLogger log) {

How to _manually_ test my changes

Kubernetes

If you don't have a real Kubernetes cluster available (most probably), you can use Minikube or Kind to test with a local cluster.

Minikube get started guide
Kind (Requires Docker) quick start

OpenShift

If you don't have a real OpenShift cluster available (most probably), you can use Red Hat's developer Sandbox for Red Hat OpenShift. The only requirement is to have a Red Hat account.

Once you have your Sandbox environment, you'll need to download the oc tool from the cluster console.
(Press the ? icon and from the context menu select Command line tools, you'll be redirected to https://$subdomain.openshiftapps.com/command-lines-tools where you'll be able to download the CLI for your platform)

first-timers-only good first issue

Source