Jimp: New Minor Release

Created on 27 Jul 2018  ·  16Comments  ·  Source: oliver-moran/jimp

@hipstersmoothie, thanks for all this. If you walk me through what's changed in this release and I'll put it live on NPM.

Since this is a change to ES version, I think we should jump major version number. So this would be 0.3.0. What do you think?

Most helpful comment

@hipstersmoothie Thank you enormously for all of this work. I've put 0.3.0 live. (Yes, I'm counting 0.X.0 releases as major releases because I'm not going to bump past an actual version 0.)

Sorry for the delay in doing this but I had difficulty accessing NPM. Now that that's fixed, let me know whenever you want to do a release and I'll review the code for malware and push it up.

Apologies for wanting to review. But the package is used by a lot of people/companies and I don't want to put anyone at risk through recklessness on my part.

My eventual intention is to hand this project over to a community. That has been stop-start for 18 months now. The approach I've been taking is to grant commit access to anyone, but for now hold back on opening up NPM rights. If a community starts to develop – or someone starts to show genuine and positive ownership over the project – then I'll happily hand over release tokens, etc.

You look like you're doing some stellar stuff – that's a great inroad into the project being moved out of my hands. Thank you!

All 16 comments

Changes in 0.2.29:

  • Lots of docs updates
  • TIFF support
  • Lots of tiny bug fixes
  • Browser version was fixed somewhere in the past year. This PR #482 makes the following work in browser again.
const Jimp = require('jimp')

Changes I want to get in for 0.3.0:

  • #473 - Babel the project and enable support for old versions of node

    • this PR remove the browser/lib from the git repo. its odd to have built files committed and was making committing and merging PRs hard.

    • removed prepublish from scripts. it was weird to have it happen every time i installed thing

    • To release now you should run npm run build first and then publish as usual

  • #477 - break project up into modules and start using require

Once those PRs are reviewed and merged I think v0.3.0 should go live.

the babel configuration targets ie8. so it should be quite compatible with many browsers.

I'd also like to get promise based returns into this release. I'm gonna do a backwards compatible implementation real quick.

Promises implemented in #486

Looks brilliant, Andrew. Thank you.

I've hit a speed bump on my side making the release to NPM. But I've teed up for a new release and will make it ASAP.

About future releases: release early and release often (I know, I know, we haven't released for over a year!). If you're in the mood for making additions, I'm happy to facilitate.

If we set up circleCI and https://github.com/ericclemmons/github-semantic-version we can make a release on every merge to master. Then we will never have to worry about communicating over an ocean to get a release going 😉

All you have to do is label the PR with patch, minor, or major and a github/npm release is made on commits to master! If you are uncomfortable giving me the npm token to set up on circleCI, you can do it and I will never have to see the key.

486 is ready to be merged if you wanna. I can help you set up circle too if you need me to.

@oliver-moran all merges have happened! (btw 0.X.0 is a minor release)

@hipstersmoothie Thank you enormously for all of this work. I've put 0.3.0 live. (Yes, I'm counting 0.X.0 releases as major releases because I'm not going to bump past an actual version 0.)

Sorry for the delay in doing this but I had difficulty accessing NPM. Now that that's fixed, let me know whenever you want to do a release and I'll review the code for malware and push it up.

Apologies for wanting to review. But the package is used by a lot of people/companies and I don't want to put anyone at risk through recklessness on my part.

My eventual intention is to hand this project over to a community. That has been stop-start for 18 months now. The approach I've been taking is to grant commit access to anyone, but for now hold back on opening up NPM rights. If a community starts to develop – or someone starts to show genuine and positive ownership over the project – then I'll happily hand over release tokens, etc.

You look like you're doing some stellar stuff – that's a great inroad into the project being moved out of my hands. Thank you!

Thank you for letting me do it! I'm excited to see where the future of jimp goes. Once web assembly is more accepted (years) we'll really be cooking 😉

Looking into bugs and fixing error handling is my next task.

Really excited that we got a release out 🎉 🎉

@oliver-moran it seems like you did not publish master. I just tried to install 0.3.0 and it has none of the work from the past year. was this intentional? It seems like you might not have pulled master in a while

Commands needed to release:

# update master then
npm run build
# then run your usual release commands

npm run build will build the browser, es5 and esm versions of jimp.

Yes. It looks like I tagged at a point before an important merge. My bad.

I've deleted the release tag. Pick a point you're happy with and tag it again as v0.3.0. I'll unpublish from NPM and put it back up again.

@oliver-moran I just tagged a release at 0.3.0 and uploaded the built packages compressed.

https://github.com/oliver-moran/jimp/releases/tag/0.3.0

make sure to npm run build before publishing! 👍

hmm i actaully need 1 more commit in there

Okay now it's good!

Great. Published. Thank you.

I had to unpublish 0.3.0 from NPM (it was a bad build). Unfortunately, NPM no longer allow you to publish over a previously published version number. So I did a no-change release at 0.3.1.

Tests are failing on some browsers tests. Looks to do with loading font files. But better to have it out than perfect.

I did a quick smoke test of a basic function and it looks good.

I’ll look into the failing tests next thing. I haven’t seen them failing
but I know there is weird stuff around font resolution. I’ll tag a new
patch release once I resolve them and then ping you
On Thu, Aug 2, 2018 at 3:20 PM Oliver Moran notifications@github.com
wrote:

Great. Published. Thank you.

I had to unpublish 0.3.0 from NPM (it was a bad build). Unfortunately, NPM
no longer allow you to publish over a previously published version number.
So I did a no-change release at 0.3.1.

Tests are failing on some browsers tests. Looks to do with loading font
files. But better to have it out that perfect.

I did a quick smoke test of a basic function and it looks good.


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/oliver-moran/jimp/issues/484#issuecomment-410086003,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABIyBF9Wdq1o-MMOuC0wpXqaqXiX3h9Nks5uM3sugaJpZM4Vkgiw
.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

laino picture laino  ·  5Comments

PainKKKiller picture PainKKKiller  ·  5Comments

Inbarasan16 picture Inbarasan16  ·  3Comments

dtrofimov picture dtrofimov  ·  5Comments

alyyousuf7 picture alyyousuf7  ·  3Comments