Jfoenix: JFXTimePicker's UI do not have a 24-hour time format

Created on 22 Mar 2017  路  4Comments  路  Source: sshahine/JFoenix

It does not appear that JFXTimePicker have an 24-hour selection UI.
http://i.imgur.com/PjOGtbD.png

A lot of users would benefit from this, as majority of the world do not use the AM/PM (at least according to Microsoft's Localization).
https://i.stack.imgur.com/43dwH.jpg


I would not mind giving it ago myself, but I am not very familiar with the project (yet), and have more pressing matters to attend to. There will come a time when I really need this, and will probably end up making it myself (unless it is already implemented by then) - but until that time, I hope this Issue will give it some attention.

Speaking of which; why not run a IRC or Discord server where users and developers can get in touch and exchange information and knowledge with the use of JFoenix and JavaFX in general? :)

Most helpful comment

As I'm also in need for an 24-hour selection UI for the JFXTimePicker, I decided to give it a shot.

timepicker timepicker

The 24-hour UI can be applied by calling setIs24HourView(true) on a JFXTimePicker instance.
To make this possible, changes in JFXTimePicker.java and JFXTimePickerContent.java were necessary. All of this can be seen in the pull request (#297) I just made.

Accedentially I fucked up JFXTimePickerContent.java regarding the formatting. As it was late at night I used my formatting configuration from IntelliJ IDEA on the file before using my brain... 馃槦
Feel free to adjust that as needed.

_Also, keep up the good work. I love your project!_ 馃挀

_EDIT: I just included the the library with the changes applied and it seems to work just fine. Also I couldn't find any issues/bugs yet._

All 4 comments

Hello,
Thanks for pointing out the issue 馃憤 , this might be implemented in the future (not planned yet).
in the meantime, feel free to add your own contribution to JFoenix.

Regards,

As I'm also in need for an 24-hour selection UI for the JFXTimePicker, I decided to give it a shot.

timepicker timepicker

The 24-hour UI can be applied by calling setIs24HourView(true) on a JFXTimePicker instance.
To make this possible, changes in JFXTimePicker.java and JFXTimePickerContent.java were necessary. All of this can be seen in the pull request (#297) I just made.

Accedentially I fucked up JFXTimePickerContent.java regarding the formatting. As it was late at night I used my formatting configuration from IntelliJ IDEA on the file before using my brain... 馃槦
Feel free to adjust that as needed.

_Also, keep up the good work. I love your project!_ 馃挀

_EDIT: I just included the the library with the changes applied and it seems to work just fine. Also I couldn't find any issues/bugs yet._

Thanks @Iw1s for your contribution 馃憤
Dont worry about the format, will change it if needed.

Regards,

Very nice 馃拑

Was this page helpful?
0 / 5 - 0 ratings

Related issues

swftvsn picture swftvsn  路  3Comments

goxr3plus picture goxr3plus  路  3Comments

evillatoro picture evillatoro  路  3Comments

deme78 picture deme78  路  3Comments

imgx64 picture imgx64  路  5Comments