Jetpack: Security: Threats Found button has formatting issue

Created on 11 Feb 2020  路  8Comments  路  Source: Automattic/jetpack

Steps to reproduce the issue

  1. Create security issue for site.
  2. Go to Jetpack -> Settings.
  3. Look at warning for Backups and security scanning, button on upper right.

Text shows Threats Found!FIX.

Screenshots
Screen Shot 2020-02-11 at 10 46 26 AM

Backup & Scan [Type] Bug

Most helpful comment

I'd replace the entire thing like so:

image

The label itself and the icon (as well as the card's content) already provide enough context for a customer to know that there are active threats.

All 8 comments

@Automattic/jetpack-design, what should this look like?

@ChaosExAnima Is that a clickable button? If so, how does this sound:

Fix threats now

But also, are we sure they are able to fix the existing threats on the following step? If not we should be more careful about the wording, to avoid setting the wrong expectation.

It seems a notice("Threat found!") with button ("FIX"):
https://wpcalypso.wordpress.com/devdocs/design/notice

Should look like this:
Screenshot 2020-02-11 at 16 00 22

Granted, it's not great... shouldn't probably be a Notice, and the whole thing should be clickable, but as a quick fix it would probably do.

@keoshi - Clicking that button takes the user to the VaultPress dashboard page, it does not fix anything.

@folletto Yeah I suppose you're right, but that design pattern tho... I wonder how effective it is.

@ChaosExAnima I'd go for See threats then.

@keoshi - Sounds good. Would we replace all the text with that, or just FIX?

I'd replace the entire thing like so:

image

The label itself and the icon (as well as the card's content) already provide enough context for a customer to know that there are active threats.

Was this page helpful?
0 / 5 - 0 ratings