Jetpack: Eventbrite Block: Default text color of modal button is too dark

Created on 29 Jan 2020  路  4Comments  路  Source: Automattic/jetpack

Steps to reproduce the issue

  1. Add an Eventbrite Block while editing a page or post
  2. Select the "Button & Modal" embed type in the sidebar

What I expected


To be able to see the button text

What happened instead

On some themes, the button text defaults to being very dark

Screenshots
If applicable, add screenshots to help explain your problem.

Screen Shot 2020-01-28 at 19 54 56

[Block] Eventbrite [Pri] High [Type] Bug

Most helpful comment

I think the change proposed by @iamtakashi is not a workaround but the intended behaviour of wp-block-button__link.
As far as I can see in Core Guten, wp-block-button__link is the inner element inside a wp-block-button.
So, it's to be expected that it malfunctions when used "outside" wp-block-button.

E.g. this is how a normal Button block is rendered in the editor:
Screenshot 2020-01-29 at 13 31 50

All 4 comments

馃憤 Twenty Nineteen is a good example of that.

If it's not going to be a big headache, adding a CSS class wp-block-button to the div.wp-block-jetpack-eventbrite.is-modal-button in the markup might be a quicker solution. Like...

Screenshot 2020-01-29 at 12 39 53

That would make the pill shape button like other buttons in the template-first themes because they override the default button style with .wp-block-button:/ Ideally, this should be fixed in the themes, but I doubt that's going to happen as no one is actively working on the template-first themes at the moment. I think Calendly block does the same workaround. What do you think?

I think the change proposed by @iamtakashi is not a workaround but the intended behaviour of wp-block-button__link.
As far as I can see in Core Guten, wp-block-button__link is the inner element inside a wp-block-button.
So, it's to be expected that it malfunctions when used "outside" wp-block-button.

E.g. this is how a normal Button block is rendered in the editor:
Screenshot 2020-01-29 at 13 31 50

Agreed, not adding the wp-block-button class was an oversight--that seems like the best solution to me because it emulates the Core button block (which was the idea in implementing to modal embed type for Eventbrite).

Was this page helpful?
0 / 5 - 0 ratings