Jetpack: "Notify me of new posts via email." still appears even after subscription module disabled.

[dericleeyy]

Steps to reproduce the issue

1. Go to Jetpack > Settings > Discussions
2. Disable
   
   
   
   • Show a "follow blog" option in the comment form
   
   
   • Show a "follow comments" option in the comment form
   
   
   • Allow users to subscribe to your posts and comments and receive notifications via email
   
   

What I expected

The comments form should hide the follow options depending on settings.

What happened instead

The following blog and comments checkbox still shows after disabling the option.
The follow comment checkbox only disappears if subscription module is disabled. However, the follow blog option is still shown.

[edequalsawesome]

Issue also reported in #13684175-hc

Follow-up here: #2140373-zen

[jeherve]

I believe this is a duplicate of #10047.

Could you test and confirm that the toggles in fact revert to their previous state, and that using the old checkboxes under Settings > Discussion works?

[edequalsawesome]

@jeherve On my self-hosted test site, I've turned off the option to subscribe to post updates in WP Admin > Jetpack > Settings > Discussion:

But the option to follow the site by email is still appearing under the comment form:

The setting for my test site on WordPress.com match the settings in WP Admin -- I don't think there's another spot that I need to check to deactivate it, but if there is, let me know and I'll give it a look!

[jeherve]

Thank you, that's helpful! It seems to be an issue with the Comment module, that overwrites the default comment form and does not appear to respect the site's module status.

To reproduce, one must:

• Disable the Subscriptions module on a Jetpack site.
• Enable the Comments module.
• Visit a post with a comment form.
• Expand the comment form.

@lancewillett It looks like you recently made some changes in D28395-code that may have caused this regression.

For a Jetpack site with the Subscriptions module disabled, stb_enabled is set to a boolean, false. If the module is enabled, once that setting is synchronized back to wpcom it will be set to a string 1.

[lancewillett]

To confirm, is this only an issue when managing settings in Calypso for a Jetpack site?

[edequalsawesome]

@lancewillett I had made the changes through WP Admin on my self-hosted test site -- the changes then synced back to Calypso, but I didn't touch anything there directly.

[xpurichan]

Also reported in 14571431-hc.

When I replicated the problem on my test site it didn't matter if I toggled the comment options in Calypso or Jetpack's WP Admin settings. I also had the subscriptions module for Jetpack enabled contrary to @jeherve steps above.

I'll also note that even if we disable the _parent_ option of "Let visitors subscribe to new posts and comments via email" we still get a checkbox to subscribe to new posts:

[julsyd]

Reported in 2296011-zen

[mbhthompson]

Reported in 2410393-zen

[katiebethbrown]

Reported in 2477894-zen, and duplicated on my test site.

Toggling off the Subscribe to Blog option via Calypso does change the stb_enabled option from 1 to an empty value (similar to the Subscribe to Comment option) but the form doesn't seem to respect the option on the front end.

[bikedorkjon]

2581814-zen

[bikedorkjon]

Customer above is still having an issue with this and the CSS we are providing them is not working which I believe is due to us loading comments in an iframe.

[joendotcom]

2638309-zen

[bikedorkjon]

2646412-zen

Just to clarify for those coming across this since the comment form loads in an iframe you cannot use CSS to hide the checkbox option in the form.

[xpurichan]

18248829-hc

[gamebits]

I'm having this problem on my site as well. Of the three options:

1. Let visitors subscribe to new posts and comments via email
2. Enable the “subscribe to site” option on your comment form
3. Enable the “subscribe to comments” option on your comment form

I've tried these settings combinations in wp-admin, with the following results:

• All three options disabled = "Notify me of new posts via email" displays.
• First option enabled = "Notify me of new posts via email" displays.
• First & second option enabled = "Notify me of new posts via email" displays.
• First & third option enabled = " Notify me of new comments via email" & "Notify me of new posts via email" display.
• All three options enabled = " Notify me of new comments via email" & "Notify me of new posts via email" display.

Similar changes in Calypso had identical results.

"Let visitors use a WordPress.com, Twitter, Facebook, or Google account to comment" is enabled.

[CompChris]

20756655-hc

[rahul020691]

The same user as Chris came back after 22 days asking for a fix
21332436-hc

[codi0]

Same problem on a newly installed site. Jetpack comments enabled, all subscription settings disabled. All configured from local install's WordPress admin area.

Very surprised this has not been fixed in (almost) a year. It's not earth shattering, but it's mis-leading to visitors and the option can't be hidden via css due to the form being loaded via iframe.

[mattptodd]

Ok, bringing some light to this. The problem only happens when you click "Let visitors use Wordpress......" as soon as that is unchecked, the form goes back to normal and the notify via email is not there. I hope that helps. I turned off all features one at a time to find when it happens. I also dug through the plugin code and have not yet found "notify me" in there.

[KokkieH]

Another report in https://wordpress.org/support/topic/cant-disable-notify-me-of-new-posts-by-email/

[griersongithub]

3481609-hc looking for a fix, I will suggest turning off the comments feature.

[kbrown9]

another report: 3556550-zen

[kbrown9]

I have a proposed solution for this bug ready for review in D54065-code.

[kbrown9]

The solution I mentioned above is now live, and this bug should be fixed. I'm closing this issue. If anyone notices problems, let us know.