Jest: license of some modules

Created on 9 Jul 2019  路  7Comments  路  Source: facebook/jest

Hi, my team would use jest-circus, jest-core, jest-runtime, jest-cli (all 24.8.0) and to approve that I've to verify all its licenses.

Now I've seen that some modules (i.e.
image
image
image
)
show this header:
*_ This source code is licensed under the BSD-style license found in the

LICENSE file in the root directory of this source tree. An additional grant
of patent rights can be found in the PATENTS file in the same directory._**

but in the root directory of the source I cannot see any BSD and PATENT license files.

Could you please clarify me what are the licenses?

Thanks for your support on this.

All 7 comments

@cpojer Is it okay to replace any obsolete comments with current license comment:

/**
 * Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved.
 *
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 */

Yes

@SimenB The 11 files with obsolete license info match the copyright line

157 files fail if I change the criterion to the following four lines:

 * Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved.
 *
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.

For example:

  • scripts/checkCopyrightHeaders.js lacks a period at end of its copyright line but you will laugh how long it took me to understand why it has been passing: includes the search string :)
  • website/static/css/custom.css has only copyright line but not license sentence

I am willing to go either way:

  • Fix 11 files and keep current criterion
  • Fix 157 files and upgrade to more complete and specific criterion

Have you done anything about this? There might not be compliance issues between MIT and BSD-style but it can be misleading while making Open Source Compliance review. It's always good to encourage such good practices when developing open source projects.
;)

@luisapace Yes, thank y鈥檃ll for finding this problem. /cc @arturrz

In #8783 and related chore #8815

  • replaced obsolete sentence about BSD with correct MIT license in 10 files
  • added missing sentence about MIT license to copyright comment in more than 100 files

So it has been fixed in the repo, although there has not been a new minor version yet

anyone have ideas that why all child directory and parent DIR don't have License.
I checked in node_modules/@jest - many child and parent DIR don't have License added.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

kgowru picture kgowru  路  3Comments

StephanBijzitter picture StephanBijzitter  路  3Comments

gustavjf picture gustavjf  路  3Comments

hramos picture hramos  路  3Comments

paularmstrong picture paularmstrong  路  3Comments