jest-resolve throws on network drives

[aliaksandr-yermalayeu]

💥 Regression Report

Jest throws error while resolving cwd
>> Error: EISDIR: illegal operation on a directory, realpath 'G:\Build'

Last working version

23.6.0
Worked up to version:
23.6.0
Stopped working in version:
24.7.1 (or earlier in 24)

To Reproduce

Steps to reproduce the behavior:
please see detailed description in #6880

Expected behavior

It should not throw

[thymikee]

Since it's a Windows issue, and none of maintainers use it daily, we'd appreciate your help on that :)

[aliaksandr-yermalayeu]

Sure, I'll create a pull request =)

[SimenB]

@aliaksandr-yermalayeu I'd prefer to make realpath-native not throw in this case, mind sending a PR to https://github.com/SimenB/realpath-native? It's supposed to return its input if anything fails.

Is this https://github.com/SimenB/realpath-native/issues/35 (which has an open PR)?

[aliaksandr-yermalayeu]

@SimenB,
While making the PR, I've found nearly ten cases of realpath usage in different jest dependencies. It seems really strange to me that half of them is wrapped with try-catch, and another half isn't.

[SimenB]

Ideally none in Jest should be wrapped. At least as long as the fallback is using whatever they passed in as-is

[aliaksandr-yermalayeu]

ok, I'll take a look

[aliaksandr-yermalayeu]

@SimenB,
I tried https://github.com/rvaidya/realpath-native/tree/feature/windowsRamdiskTry2 and it works for me. If you are ok with @rvaidya changes, I may create a PR from his repo.

[SimenB]

They opened up a PR now, I'll try to land and release it tomorrow

[heavenkiller2018]

no one to fix the only bug?oh, my god!

[SimenB]

Hopefully fixed (although not released). Please check Jest 26 when we release it. If it's still not fixed, we might need to catch some more