Jest: console.assert from Puppeteer showing up in terminal after upgrading to v22.3.0

Created on 15 Feb 2018 · 9Comments · Source: facebook/jest

Do you want to request a _feature_ or report a _bug_?

Bug

What is the current behavior?

console.assert from puppeteer is showing up in terminal when running tests.

What is the expected behavior?

The console.assert calls didn't show up in v22.1.4

Source

cdeutsch

👍2

Most helpful comment

@emilianionascu

yourproject/tests/something.test.js

console.assert = jest.fn();
describe('your Jest test suite start here', () => {
  test('your unit test (or whatever you are doing)', () => {
    // do something
  });
});

works for me.

clement-bramy on 20 Feb 2018

👍2

All 9 comments

Would the recent changes to Console.js or buffered_console.js cause this?
https://github.com/facebook/jest/compare/v22.1.4...v22.3.0

cdeutsch on 15 Feb 2018

Yeah, this is #5514. The one from Page.js:648 looks legit, but we should not print the stackframe if there's nothing to log in an assert.

@ranyitz mind taking a look?

SimenB on 15 Feb 2018

@SimenB I agree, I will fix it later on today.

ranyitz on 15 Feb 2018

👍1

Thank you for the fix. Is there a new release coming for it or perhaps a way to disable the assertions until the official fix?

emilianionascu on 19 Feb 2018

you should be able to do console.assert = jest.fn() in a setupfile

SimenB on 19 Feb 2018

@SimenB could you be more specific? I'm rather new to Jest, trying to use it with Puppeteer in a regression testing suite. I've created a jest.config.js file and tried to set it there assuming that console.assert were global. That didn't work.

emilianionascu on 20 Feb 2018

@emilianionascu

yourproject/tests/something.test.js

console.assert = jest.fn();
describe('your Jest test suite start here', () => {
  test('your unit test (or whatever you are doing)', () => {
    // do something
  });
});

works for me.

clement-bramy on 20 Feb 2018

👍2

22.4.0 is released, btw, so this shouldn't be needed anymore

SimenB on 20 Feb 2018

Oh, this wasn't closed.