Jest-puppeteer: Supporting puppeteer 2.0

Created on 7 Nov 2019  路  4Comments  路  Source: smooth-code/jest-puppeteer

馃殌 Feature Proposal

Support a peer dependency of Puppeteer 2.0 rather than requiring a 1.x version

Motivation

We depend on this package for our tests, and we'd like to run them on macOS Catalina, but we've had issues with the version of chromium necessary for these tests, on Catalina. Puppeteer 2.0 supports a newer version of chromium that should support Catalina better.

Example

We would use this to run the functional tests for a project I work on.

Pitch

Supporting the latest browsers will keep this package relevant! :)

Most helpful comment

@ryanjwilke Yeah look in package.json only ^1.5.0 is supported:

"peerDependencies": {
  "puppeteer": "^1.5.0"
},

@paperbd I've opened a pull request to fix it here: https://github.com/smooth-code/jest-puppeteer/pull/289

All 4 comments

I agree. I've already upgraded to using puppeteer 2.0, but I keep getting this warning:

warning " > [email protected]" has incorrect peer dependency "puppeteer@^1.5.0"

@ryanjwilke Yeah look in package.json only ^1.5.0 is supported:

"peerDependencies": {
  "puppeteer": "^1.5.0"
},

@paperbd I've opened a pull request to fix it here: https://github.com/smooth-code/jest-puppeteer/pull/289

@colinrotherham Thanks. No rush for me really. All my tests still work just fine with 2.0 :)

Thanks for working on a fix for us all already.

Looks like https://github.com/smooth-code/jest-puppeteer/pull/289 is merged now, so I'll close this. Thanks so much @colinrotherham!

Was this page helpful?
0 / 5 - 0 ratings