Jest-puppeteer: Bring Typescript types into repository

[ifiokjr]

🚀 Feature Proposal

Add Typescript types directly to the packages within this repository

Motivation

This is was discussed in #8 but a lot of has changed since then.

See the pitch section for more information. In short, jest now uses TypeScript internally and relying on types from a none DefinitelyTyped package is a lot more difficult as it needs types to be made available via types-publisher as well.

Example

Going forward we would no longer need to add @types/expect-puppeteer and @types/jest-environment-puppeteer.

Pitch

I've just opened a DefinitelyTyped pull request to export the PuppeteerEnvironment default export from jest-environment-puppeteer library. The build is currently failing because it relies on none DefinitelyTyped types since Jest now uses typescript directly within its codebase. The potential solution is another PR to the types-publisher package but even then I have no way of testing if this solution will work until the PRs are merged.

It seems much simpler to just bring the type definitions into this repo.

[gregberge]

Hello @ifiokjr, I don't use TypeScript, that's why adding types to this repository is not a good idea. We need a TypeScript user as maintainer in the project if we want to do so? Are you interested?

[ifiokjr]

@neoziro this sounds like something I could help with. I've just sent you an email with a minor question.

[gregberge]

@ifiokjr I answered!

[ifiokjr]

@neoziro thanks!

I'll create a PR this weekend 😄🤞

EDIT

This week...

[ifiokjr]

@neoziro I'll close this for now. It's been a busy few weeks and likely to be especially busy for the next month or so.