Jellyfin-android: libre-release.apk added non-libre elements
v2.2.0 just introduced Firebase Data Transport, Google Mobile Services, Google Cast… bringing the *libre-release.apk even in size to *proprietary-release.apk. None of these were present in v2.1.3 – and none of these are "libre".
It hopefully was just an accident. Can you please "revert" that? Thanks in advance!
IzzySoft
All 9 comments
This shouldn't happen, I'll investigate.
nielsvanvelzen
on 20 Nov 2020
We added a new dependency on com.google.android.exoplayer:extension-cast:2.12.1 in #232. This added some proprietary libraries to our build.
nielsvanvelzen
on 20 Nov 2020
Ah, thanks – so I was on the right track. I suspected something being dragged-in by dependency, but wasn't sure where to look. Good you found it that fast :+1:
IzzySoft
on 20 Nov 2020
No problem, I'm glad you told us otherwise we wouldn't have noticed :)
nielsvanvelzen
on 20 Nov 2020
I wouldn't have noticed either, but my library scanner yelled at me. Always good to have some safe-guards in place(s) :smile:
IzzySoft
on 20 Nov 2020
Thanks Niels! Looking forward to v2.2.1 then. Any ETA for its release, so I can make sure to check (and remove those AntiFeatures again)?
IzzySoft
on 22 Nov 2020
Working on the release now. We decided for a quick release that fixes this issue and it also includes some changes needed for the fdroiddata merge request (to hopefully have reproducible builds working).
PS: Credits go to @Maxr1998 for a proper fix :)
nielsvanvelzen
on 22 Nov 2020
It's released now!
Downloads at the usual places:
nielsvanvelzen
on 22 Nov 2020
That was fast, thanks! Triggered the update manually (to have scanner results and be able to fix AntiFeatures before the sync) – this was a full success! Removed the AntiFeatures right away. So in about 2 hours from now, the changes will go live – with Jellyfin showing up shiny, new and clean, yay! :tada:
So again: Thanks to @nielsvanvelzen for picking up quickly – and to @Maxr1998 for fixing it that quickly as well!
IzzySoft
on 22 Nov 2020
Related issues
tuxrinku
·
5Comments
Norde
·
6Comments
P-Daddy
·
6Comments
SteveDinn
·
4Comments
Aerion
·
3Comments
Most helpful comment
That was fast, thanks! Triggered the update manually (to have scanner results and be able to fix AntiFeatures before the sync) – this was a full success! Removed the AntiFeatures right away. So in about 2 hours from now, the changes will go live – with Jellyfin showing up shiny, new and clean, yay! :tada:
So again: Thanks to @nielsvanvelzen for picking up quickly – and to @Maxr1998 for fixing it that quickly as well!