Jellyfin-android: Use EditorConfig from Android TV app
We have 2 Android apps now based on Kotlin. I think it would be a good thing to have the same styling guidelines for both of them. At this moment the android-next app uses spaces as indentation while Android TV chose to use tabs.
The EditorConfig for Android TV is here. We could just copy it over and reformat all Kotlin files.
nielsvanvelzen
All 6 comments
I see, while I'm personally not a fan of using tabs for indentation, I can still pull in config if the majority of the team is in favor. I mean, I don't want to start a flame-war. 馃槅
Maxr1998
on 7 Aug 2020
I'm also not a fan of tabs.
dkanada
on 7 Aug 2020
It wasn't my intention to start a discussion. We already had that when choosing the indentation for the ATV app. We could use a different indentation for both repositories but it seems more logical to have the consistency.
nielsvanvelzen
on 7 Aug 2020
I encourage everyone to read this post on the topic. It certainly solidified my opinion to be firmly in favor of tabs.
https://www.reddit.com/r/javascript/comments/c8drjo/nobody_talks_about_the_real_reason_to_use_tabs/
thornbill
on 7 Aug 2020
There are no half tabs
cromefire
on 7 Aug 2020
Here's the official code style: https://kotlinlang.org/docs/reference/coding-conventions.html
Let's just use that
cromefire
on 7 Aug 2020
Related issues
jorritsmit
路
7Comments
willymilkytron
路
5Comments
sopidos
路
3Comments
sheckandar
路
3Comments
vegedb
路
6Comments
Most helpful comment
I encourage everyone to read this post on the topic. It certainly solidified my opinion to be firmly in favor of tabs.
https://www.reddit.com/r/javascript/comments/c8drjo/nobody_talks_about_the_real_reason_to_use_tabs/