The Eclipse Foundation aims to provide a common Jakarta EE 8 release, which means we should release JAX-RS 2.1.1 (i. e. more or less JAX-RS 2.1 + EPL + Essential Bug Fixes + our share of the TCK, hence content of our repo's EE4J_8 branch).
This issue serves as a place for planning and performing that release.
Issues for this particular release can be found here: https://github.com/eclipse-ee4j/jaxrs-api/milestone/7.
Is somebody already preparing this?
@mkarg Yes, I can work on this one. I will be running signature tests with the TCKs to make sure we can release this.
@spericas Great! Thanks! :-)
@spericas I have prepared nightly builds (see #643) on EF infrastructure, just in case you're ready to commit the TCK. :-)
@mkarg :-) Thanks, I will take a look.
Now that we have nightly builds in EF Nexus and the release pipeline in OSSRH set up, what is open wrt the release? TCK? Spec? Bug collections? What shall people help with?
@mkarg With the help of @jansupol it was verified that 2.1.1-SNAPSHOT passes the TCKs. I think we should drop SNAPSHOT via a PR and start with the voting to push 2.1.1 to OSSRH (unless I'm missing some other step).
@spericas Sounds good, but can we wait with this final PR until the weekend? I'd like to add some of the bug fixes we merged into 2.2-SNAPSHOT. I would send you a list with the commit IDs so you can add them to your PR. Or did you already do that (I did not find any in the EE4J branch)?
@mkarg I thought we had merged those when deleting 2.1.1-SNAPSHOT, but I guess they were not there. Yes, let's get those in and prepare the branch to kick off the release. I'll look for those commit IDs, but if you have them handy please paste them here.
I believe these are the two commits:
https://github.com/eclipse-ee4j/jaxrs-api/commit/c8e9d188767778a04c547d7b24e0ce885bd3a1e9
https://github.com/eclipse-ee4j/jaxrs-api/commit/4880f9ce2f41a2c70e91dd95edd3d7fbe7ee0535
Agreed?
We could possibly merge more. What about adding these, too?
https://github.com/eclipse-ee4j/jaxrs-api/commit/82496b3d76f8339af444700ed8a2f540401310e4
https://github.com/eclipse-ee4j/jaxrs-api/commit/a292276056f0a8d938a62ec2abd3a9d3d07baec9
https://github.com/eclipse-ee4j/jaxrs-api/commit/a046a50d0dfc60c8e24002aa7a437b20ddcc9e91
https://github.com/eclipse-ee4j/jaxrs-api/commit/e781b332843f00c8776cd47c718008a676d9c75a
https://github.com/eclipse-ee4j/jaxrs-api/commit/5afcef5a33ad65554fef382593c7ec7c5bd850f5
50cab0b0a3ae69f8ebf2768ab5661c946f847428
@mkarg I have the last two ready in my fork. The other ones are OK except for e781b33 since I believe there was some discrepancy in the implementations and moving from 2.1 to 2.1.1 should require no changes IMO.
@spericas Agreed, let's keep e781 out. Ok, so after few cherry-picks on your side we're ready to release, right? What about that EF release review stuff, is that ready or shall I prepare something?
@mkarg The commit message for this one:
https://github.com/eclipse-ee4j/jaxrs-api/commit/82496b3d76f8339af444700ed8a2f540401310e4
mentions version 2.2. I sort of understand why and would suggest that we leave it out as well for 2.1.1. Other than that, the PR is ready on my end.
That was a typo. Actually it should read "According to JAX-RS 2.1 specification". So we could add it to 2.1.1.
@mkarg Ok, PR has been submitted.
Release staged on OSSRH and passed validation: https://ci.eclipse.org/jaxrs/job/Publish%20Release/11/.
Next step is IP Approval and Release Review, according to https://docs.google.com/drawings/d/1ZoEf7lvzBOB1PIq7q7JdFbTvTlAgzCkvIiEDH-CYJL4/edit.
@mkarg My understanding is that we are on step 6 here:
https://github.com/eclipse-ee4j/ee4j/wiki/How-to-release-the-first-Eclipse-version-of-projects
So just need to kick off a new release on our project page. I'm confused about the IP Approval that you mentioned. What is that?
@spericas I assume the term "IP Approval" found in the chart means step 9 in Dmiry's list.
@spericas If you want I can do the EF paperwork, but for that, we apparently need to agree upon an official release date first (I think this is due to legal issues). I propose 2018-09-10 for 2.1.1. Then the papaperwork is:
IIUC that should be all. Shall I do it or are your doing it?
@mkarg I'm OK with the proposed release date. I'll go ahead with step (1) and then we can coordinate the others.
@spericas Ok, just ping me when I shall do something.
https://projects.eclipse.org/projects/ee4j.jaxrs/releases/2.1.1
@mkarg Do you have full access to view and edit the release?
@spericas Yes, I could press "Save" (without changing anything) and it says "Updated release".
@mkarg Great, I filled out some basic info about the release now. If you want to start with (2) and (3) from your list, go ahead. Otherwise, I'll get back to this later.
@spericas Okay I will do (2) and (3).
@spericas (2) is done (https://projects.eclipse.org/projects/ee4j.jaxrs/releases/2.1.1/iplog/preview; https://dev.eclipse.org/ipzilla/show_bug.cgi?id=17366).
@spericas (3) is done (https://projects.eclipse.org/projects/ee4j.jaxrs/reviews/2.1.1-release-review; mail sent to PMC and EMO)
@spericas (2) IP log is approved. http://dev.eclipse.org/ipzilla/show_bug.cgi?id=17366
@spericas (3) PMC has approved release 2.1.1. Still waiting for EMO approval (review still is in pending state)
@spericas (3) EF release review is successfully finished since yesterday (https://bugs.eclipse.org/bugs/show_bug.cgi?id=538340), so as announces I will technically release JAX-RS 2.1.1 to Maven Central on 2018-09-10. If you know any showstoppers then please let me know, otherwise this is the point of no return, as we cannot remove or update artifacts on Maven Central.
@mkarg No showstoppers that I know, green light!
@spericas Pressed the button. It will take a while to sync. Should be available at The Central Repository on Monday (or even on Sunday).
@spericas Wow, sync was pretty fast: Building Jersey mvn tells me Downloaded from central: https://repo.maven.apache.org/maven2/javax/ws/rs/javax.ws.rs-api/2.1.1/javax.ws.rs-api-2.1.1.jar (127 kB at 220 kB/s)!
Closing this issue with your kind permission, as this proofs we just successfully published our first release!
Awesome! Thanks @mkarg!
BTW: AFAIK the sync to Maven central only takes about one hour. But the update of the search index on search.maven.org takes much longer.
Yes, the sync just needs minutes, but indexing indeed needs hours. Anyways, after one night it finally showed up: https://search.maven.org/artifact/javax.ws.rs/javax.ws.rs-api/2.1.1/bundle
-Markus
From: Christian Kaltepoth [mailto:[email protected]]
Sent: Sonntag, 9. September 2018 08:06
To: eclipse-ee4j/jaxrs-api
Cc: Markus KARG; Mention
Subject: Re: [eclipse-ee4j/jaxrs-api] Jakarta EE 8: Release JAX-RS 2.1.1 (#638)
Awesome! Thanks @mkarg https://github.com/mkarg !
BTW: AFAIK the sync to Maven central only takes about one hour. But the update of the search index on search.maven.org takes much longer.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/eclipse-ee4j/jaxrs-api/issues/638#issuecomment-419693307 , or mute the thread https://github.com/notifications/unsubscribe-auth/ABn3tzsLfo0va-bV_mkskASYKL50zUJoks5uZK--gaJpZM4VZm5O . https://github.com/notifications/beacon/ABn3tzVZZNRuHISSdiWqGblCysXPA_gRks5uZK--gaJpZM4VZm5O.gif
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/eclipse-ee4j/jaxrs-api","title":"eclipse-ee4j/jaxrs-api","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/eclipse-ee4j/jaxrs-api"}},"updates":{"snippets":[{"icon":"PERSON","message":"@chkal in #638: Awesome! Thanks @mkarg!\r\n\r\nBTW: AFAIK the sync to Maven central only takes about one hour. But the update of the search index on search.maven.org takes much longer."}],"action":{"name":"View Issue","url":"https://github.com/eclipse-ee4j/jaxrs-api/issues/638#issuecomment-419693307"}}} [ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/eclipse-ee4j/jaxrs-api/issues/638#issuecomment-419693307", "url": "https://github.com/eclipse-ee4j/jaxrs-api/issues/638#issuecomment-419693307", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Re: [eclipse-ee4j/jaxrs-api] Jakarta EE 8: Release JAX-RS 2.1.1 (#638)", "sections": [ { "text": "", "activityTitle": "Christian Kaltepoth", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@chkal", "facts": [ ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"eclipse-ee4j/jaxrs-api\",\n\"issueId\": 638,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "targets": [ { "os": "default", "uri": "https://github.com/eclipse-ee4j/jaxrs-api/issues/638#issuecomment-419693307" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 359034446\n}" } ], "themeColor": "26292E" } ]
Awesome, great job!
Tagged as "2.1.1" so it shows up in Github "Releases" view now.
Most helpful comment
@spericas (3) EF release review is successfully finished since yesterday (https://bugs.eclipse.org/bugs/show_bug.cgi?id=538340), so as announces I will technically release JAX-RS 2.1.1 to Maven Central on 2018-09-10. If you know any showstoppers then please let me know, otherwise this is the point of no return, as we cannot remove or update artifacts on Maven Central.