Javacv: Java2DFrameConverter.cloneBufferedImage makes images black

[d-a-gerashenko]

What for is this condition "type == BufferedImage.TYPE_CUSTOM" used in the method Java2DFrameConverter.cloneBufferedImage?
https://github.com/bytedeco/javacv/blob/master/src/main/java/org/bytedeco/javacv/Java2DFrameConverter.java#L75
It makes all my images black. Without this condition all work fine.

[saudet]

It just tries to create a BufferedImage of the same type, but in the case of TYPE_CUSTOM, we probably need to do more work to support all kinds of formats...

[d-a-gerashenko]

It returns new BufferedImage with the same type but without data.
If I use this:

Java2DFrameConverter converter = new Java2DFrameConverter();
Java2DFrameConverter.cloneBufferedImage(converter.convert(frame));

it returns:

return new BufferedImage(bi.getWidth(), bi.getHeight(), type);

Maybe it's better to mark this condition with @todo (or just comment it) and to put only this code in the method?

return new BufferedImage(bi.getColorModel(), bi.copyData(null), bi.isAlphaPremultiplied(), null);

[saudet]

Well, that won't return an image of the right type. So let's get this fixed properly.

[saudet]

We could adopt this solution: https://stackoverflow.com/a/19327237/523744

Could you check that it works in your case? And please do send a PR! Thanks

[d-a-gerashenko]

Isn't it the same as my code above? Are you talking about this one:

static BufferedImage deepCopy(BufferedImage bi) {
    ColorModel cm = bi.getColorModel();
    boolean isAlphaPremultiplied = cm.isAlphaPremultiplied();
    WritableRaster raster = bi.copyData(null);
    return new BufferedImage(cm, raster, isAlphaPremultiplied, null);
}

I just replaced this:

ColorModel cm = bi.getColorModel();
boolean isAlphaPremultiplied = cm.isAlphaPremultiplied();

with this:

bi.isAlphaPremultiplied();

[d-a-gerashenko]

And both of them work properly.

[saudet]

No, the one under, this one: https://stackoverflow.com/a/19327237/523744

[d-a-gerashenko]

Ok. I'll test it.

[d-a-gerashenko]

I also have found this method:
https://github.com/bytedeco/javacv/blob/master/src/main/java/org/bytedeco/javacv/Java2DFrameUtils.java#L47

Both of them passed the test.

[saudet]

Right, that's the same thing though. It doesn't copy the imageType when it's not equal to TYPE_CUSTOM.

[d-a-gerashenko]

Now what's the plan? Do I have to create PRs for both of this files or for the Java2DFrameConverter only?

[saudet]

Java2DFrameUtils should be using Java2DFrameConverter, so let's do that. Sounds good?

[d-a-gerashenko]

Yes. I was going to do it the same way.

[saudet]

Released in version 1.3.3. Thanks for your contribution!