As described in this post https://groups.google.com/forum/#!topic/aureliusgraphs/qd71sHiCHYI , we should consider enabling this configuration by default to avoid performance degradation.
Need to investigate why this has been disabled previously.
Matthias turned fast-property off by default for the Titan 1.0.0 release, for no particular reason. I suggest we turn it back on, or at least discuss this configuration option in the vertex-centric index bit of the documentation
I think it makes good sense to default this back to true. Perhaps we can start a discussion on janusgraph-dev and assume lazy consensus in 72 hours if no one objects just in case anyone has a good reason to leave it false.
Well - I guess defaulting the value to true would make sense as long as the number of properties on an element is reasonable - which is probably the majority of use cases. The graph that we have (in titan at the moment), has a few nodes containing ~25 properties. Hopefully that number is small enough.
Can the OP of that thread comment on the number of properties that were there on the elements?
I was the OP on that thread. For our system, we usually have ~5-10 properties on any given vertex, and all property data is short (integers or short strings). I do think that the majority of use cases would prefer fetch all in one go, given that the new-to-1.0 one-at-a-time default dramatically slowed things down due to all the additional trips to the back end.
Thread started here: https://groups.google.com/forum/#!topic/janusgraph-dev/P94zxhUbubc. No one piped up so I think we should go ahead and turn fast-property back to true.
I'm picking it up, make some tests and debugs, if I don't find anything
weird, I'll PR to the project...
Cheers,
Rafa
On Sat, Feb 18, 2017 at 11:35 AM Ted Wilmes notifications@github.com
wrote:
Thread started here:
https://groups.google.com/forum/#!topic/janusgraph-dev/P94zxhUbubc. No
one piped up so I think we should go ahead and turn fast-property back to
true.—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/JanusGraph/janusgraph/issues/104#issuecomment-280856920,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADAxfoy95CyfiTbU1aWGGFnoZyl42A-9ks5rdx3ZgaJpZM4L9aRq
.
Excellent, thanks @rafatuita.
@rafatuita, @twilmes What's the status on this? I could have sworn this was done but I'm not finding the PR.
I was sure that I had pushed a PR for this as well, I just checked and I've been using it on my production system for a while now... anyways, let me push it up.
Most helpful comment
I was sure that I had pushed a PR for this as well, I just checked and I've been using it on my production system for a while now... anyways, let me push it up.