Janus-gateway: Installation issue

[GiaCatKhongVinh]

Hello, I'm getting an issue with the installation of Janus-gateway. Screenshot attached. It says the errors come from the newly added events/janus_wsevh.c.

Please help to check. Thanks!

[GiaCatKhongVinh]

Sorry, I found out i used libwebsockets-dev 2.0.3-3build1.

[lminiero]

Mh it still means we should check the libwebsockets version, I wasn't aware that flag wasn't available on older versions. I'll add a check for that.

[lminiero]

Should be fixed in master, now: if libwebsockets is older than 2.4.0, we use LWS_CALLBACK_CLOSED instead of LWS_CALLBACK_CLIENT_CLOSED. Not sure if that's the only thing that could cause it to break, but this should be solved at least.

[tgabi333]

@GiaCatKhongVinh How did you get such an old libwebsocket? is it embedded into a certain linux distro?

[GiaCatKhongVinh]

@tgabi333: I'm using Ubuntu 18.04 distro and I had installed libwebsocket from the repo using command:
sudo apt-get install libwebsockets-dev

[tgabi333]

@lminiero from the changelog it seems to me that LWS_CALLBACK_CLIENT_CLOSED was introduced in v3.0.0, but there is a 2.4.1 and 2.4.2 release which is broken now?

[lminiero]

I checked the version in the commit where this was added, and it said 2.4.0 there. I don't have those installed so I can't verify the check actually works myself.

[lminiero]

You're correct that the changelog mentions 3.0.0, though, I'll fix the check (again :sob: )