Jamulus: Additions to instrument list

Created on 22 Apr 2020  Â·  46Comments  Â·  Source: corrados/jamulus

It would be great to get all the standard orchestral instruments added to the Instrument list. It looks to me that they're all there except these:

  • viola
  • oboe
  • bassoon
  • percussion (not the same as Drum Set!)
  • tympani (though will there ever be call for this in Jamulus?)
  • harp

Also see this thread in the forum where Bodo requested some other more esoteric instruments, and suggested a procedure for adding them. I also don't know if it makes sense to add variants of the standard instruments, like bass clarinet, contrabassoon, English horn.

As the list grows (which seems good to me), it would also be nice to have some sensible sorting to make it easier to find specific instruments.

feature request

Most helpful comment

@corrados Would there be a problem with allowing free text input (eg an "Other..." option) for the instrument list? They would not be able to specify an icon of course unless we just had a generic one.

All 46 comments

@corrados Would there be a problem with allowing free text input (eg an "Other..." option) for the instrument list? They would not be able to specify an icon of course unless we just had a generic one.

I suggested to add instruments more or less common in folk music.

  • Drum (for any special type of drum not yet listed)
  • Percussion (for any type or set of percussion instruments not yet specifically listed)
  • Bodhran (special type of drum, very common in Irish folk music)
  • Bouzouki (related to mandolin or lute, very common in Greek and Irish folk music, there are differences between Greek and Irish versions)
  • Nyckelharpa (keyed string instrument played with a bow, very common in Swedish folk music, sometimes used in other folk music)
  • Hurdy-gurdy (keyed string instrument played by turning a wheel, often used in folk music)
  • Jew's harp (used in folk music)
  • Tamburello

From a folk musicians point of view, these are not esoteric at all.

As the instruments have an assigned type it might be possible to sort/group or filter by this type if the list gets longer. I also suggest to alliw alphabetical sorting (in addition to filtering or grouping by type).

Additional thought:
Would it be possible to extend the protocol to transmit an additional instrument name?
This could be used with an instrument selection "none" or "other" if there is no suitable instrument in the list or to add a more specific name or type to an existing instrument, e.g. "pedal harp", "lever harp" or "Celtic harp", "Bohemian harp" or Greek bouzouki vs. Irish bouzouki.
Older versions of the software should ignore this information.

Bodo

For the icons of the instruments I will either provide links to images with a suitable license or create images myself.

Maybe creating a table of instruments with different categories would be best than having a dropdown menu, to enable a bigger instrument list with easy to find instruments.

Getting images without infringing copyright would be easy through a google image search and filtering the results by usage right.

Would it be possible to extend the protocol to transmit an additional instrument name?

I think it's important to keep the transmission of data to a minimum as to not affect the audio transmission as much as possible.

it would also be nice to have some sensible sorting to make it easier to find specific instruments.
Maybe creating a table of instruments with different categories would be best than having a dropdown menu, to enable a bigger instrument list with easy to find instruments.

Yes, this is no big deal to support that in the GUI. Since the number of instruments was low, there was no need in the past.

Would there be a problem with allowing free text input (eg an "Other..." option) for the instrument list?

I am not a fan of such a solution. Let's keep what is currently implemented and just enlarge the list.

Getting images without infringing copyright would be easy through a google image search and filtering the results by usage right.

I do not think that it is that easy. Copyright issues can easly destroy an open source project...

For the icons of the instruments I will either provide links to images with a suitable license or create images myself.

Getting the pictures is the hardest part. If you have a good picture which free licence, you simply have to select an appropriate name for the instrument and select a catagory:
OTHER_INSTRUMENT,
WIND_INSTRUMENT,
STRING_INSTRUMENT,
PLUCKING_INSTRUMENT,
PERCUSSION_INSTRUMENT,
KEYBOARD_INSTRUMENT,
MULTIPLE_INSTRUMENT

I start with the first instrument here. This file contains is an image for a bodhran in SVG and PNG format. (A .svg file is not accepted here, that's why I had to use a .zip file.)

bodhran-icon-2.zip

I created the SVG file (a vector graphics format) myself with inkscape and exported it as 27x27 pixel PNG file because many existing instrument images have at least one size of 27 pixels. (If necessary I can also create a pixel image in a different size.)

Bodhran is a PERCUSSION_INSTRUMENT

The image is my own work. I provide the image files under the license CC0.
https://creativecommons.org/share-your-work/public-domain/cc0/

I do not think that it is that easy. Copyright issues can easly destroy an open source project...

A bunch of picture searching engines allows to filter by licenses. Including flickr, google images, wikimedia and probably others.

The image is my own work. I provide the image files under the license CC0.

Thank you.

The list currently has a "guitar + vocal" but no "keyboard + vocal".
Could it be added ?

If you provide my with an icon, yes.

I suggested to add instruments more or less common in folk music.
From a folk musicians point of view, these are not esoteric at all.

Sorry! I guess I just meant I didn't know what they were :) I should get out more...

keysvocal

What is the licence of that icon?

Sorry all I did is merge the two existing images (I rotated the keyboard). All rights are with the original guy who did the two icons

Ok, great. Then I will add it to Jamulus now. Thanks.

Thank you corrados.

Regarding other new instruments (like the ones mentioned in the initial post): Please create icons for me and I will include them in the Jamulus software then.

Here is a bassoon. I made it (in inkscape), since I thought the free ones I could find online didn't really look distinctively bassoon-like. I hereby release it into the public domain, via CC0.

I'm posting a zip file containing both the original svg in case that's helpful, as well as a png I exported at about the as the other instrument icons. Let me know if this is what's needed, or if I should do something different.

I'm also working on a oboe, and then maybe percussion and tympani.

For viola, I'm not sure how to distinguish it from a violin, so maybe just use the same icon.

bassoon.zip

It's added. Thank you.

Here is an oboe. Same deal: made in Inkscape, released to public domain as CC0.
oboe.zip

Oboe just added, thanks.

And a harp... Also inkscape, public domain CC0
harp.zip

For viola, I suggest using the violin icon, but rotated just to be different. Like this.
viola

What about a different color of the instrument for the viola to distinguish the viola from the violin? What do you think?

What about a different color of the instrument for the viola to distinguish the viola from the violin?

I don't know... Real violas are the same color as violins. But they do hold them at an
odd angle :) (Because, you know, they're big--I've had a principle viola jab me with his scroll, sitting inside first stand cellos!!)

But they do hold them at an odd angle :)

By that token, maybe I should have rotated the other way, with scroll more to the left.

Like this.
viola

It will look different in the list, at least.
It's also true that many violists also play violin, so maybe not so bad to confuse them at first glance.
But I guess it could be a different color too.

I have now added the viola. I have use the mirror-symmetric version and I adjusted the color a bit:
https://github.com/corrados/jamulus/blob/master/src/res/instruments/viola.png
We may change this png later on but as a first start I think it is acceptable.

tympani (though will there ever be call for this in Jamulus?)

I agree with your comment. I guess nobody will using this with Jamulus. So I think it does not make sense to add this.

I have created this icon for the Congas instrument and freely contribute it The image is my own work. I provide the image file under the license CC0.
congas_icon.zip

I have just added your congas icon. Thank you.

Thanks you, Volker! Will submit a Bongo soon.

On Fri, May 8, 2020 at 10:53 AM Volker Fischer notifications@github.com
wrote:

I have just added your congas icon. Thank you.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/corrados/jamulus/issues/131#issuecomment-625882305,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABO62UHSHLNE272HQ5NKJULRQQTF5ANCNFSM4MOPZXSQ
.

I have created this icon for the Bongo
bongo.zip
instrument and freely contribute it The image is my own work. I provide the image file under the license CC0.

It's added, thanks.

Hi,
As a choir singer, we use Jamulus for our rehearsals. I'd like to add vocals icons for each tipical choir voices: sopranos, altos, tenors, basses. Would it be possible? Also it would be great if we could sort the channels by instrument, so we can have same voices together by groups.
Thanks for your efforts in making this software so awesome!

Alberto

Would it be possible?

Yes, if you provide me with the instrument icons.

Also it would be great if we could sort the channels by instrument, so we can have same voices together by groups.

There is already a feature request for it: https://github.com/corrados/jamulus/issues/178

Hi,

Please find below icons for choir voices, sopranos, altos, tenors and basses made by myself, if you consider to add them to the instruments list as suggested.

instrchoirvoices.zip

Thanks,
Alberto

Thanks Alberto, they look funny :-). What is the licence for these pictures? Is it under the license CC0?

The mans mouth looks like a photo. Was this photo taken by you or did you use one from the internet?

Hi,

I took them from pngwing.com. I think they allow use of the images if it's
not for commercial.

Alberto

El dom., 17 may. 2020 a las 9:43, Volker Fischer (notifications@github.com)
escribió:

Thanks Alberto, they look funny :-). What is the licence for these
pictures? Is it under the license CC0?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/corrados/jamulus/issues/131#issuecomment-629757368,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACMBI3JWPR2PZGYFQPHMQ73RR6ISFANCNFSM4MOPZXSQ
.

On the homepage of pngwing.com I can only read "Transparent background png images for designers". I cannot find a licence file for any of the pictures. It is also unclear who has created them. There is a "contact us" but this only opens a new email. I do not see a true "About" page or something similiar. To me this looks very suspicious. I would not want to include any picture from that page in Jamulus. Unfortunately, this is too critical.
Can you please look at https://openclipart.org if you find a similar picture?

Hi,

No problem, I understand, I'll look for new ones. What is the max size of
the icons? And I'm thinking about using pictures from my own, is it ok?

Alberto

El dom., 17 may. 2020 a las 10:20, Volker Fischer (notifications@github.com)
escribió:

On the homepage of pngwing.com I can only read "Transparent background
png images for designers". I cannot find a licence file for any of the
pictures. It is also unclear who has created them. There is a "contact us"
but this only opens a new email. I do not see a true "About" page or
something similiar. To me this looks very suspicious. I would not want to
include any picture from that page in Jamulus. Unfortunately, this is too
critical.
Can you please look at https://openclipart.org if you find a similar
picture?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/corrados/jamulus/issues/131#issuecomment-629760922,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACMBI3OODH2UOUIER3CYEJ3RR6M4ZANCNFSM4MOPZXSQ
.

The height should not be larger than 27 pixel and the width not more than 35.
If you use your own pictures, that should be fine.
To have a proof of licence, please do it like above, e.g., "_I provide the image file under the license CC0._"

Ok, hope this works. My own pictures below.
I provide the images files under the license CC0.

instrvocalchoir.zip

So excited I can be a tiny part of this software!

Alberto

I just added your icons. Thank you for your contribution.

I think it does not make sense to keep this Issue open. If anyone wants to contribute a new instrument picture, he/she should create a new Issue for that. I'll close this one now.

Was this page helpful?
0 / 5 - 0 ratings