Jaeger: Make Go client support JAEGER_ENDPOINT env var and use it in hotrod

Created on 9 Jul 2018  路  5Comments  路  Source: jaegertracing/jaeger

Per https://github.com/jaegertracing/jaeger/pull/915#discussion_r200855019

I think a cleaner approach is to change Go client to respect JAEGER_ENDPOINT env var, similar to Java client, which would allow configuring either UDP or HTTP reporter from env vars only, without adding extra flags to the HotROD binary.

  • [x] Go client to respect JAEGER_ENDPOINT
  • [ ] Update HotROD to remove extra flags
areclient-libs good first issue help wanted
Source
picture yurishkuro

Most helpful comment

@eundoosong 2.15 is out

picture black-adder on 10 Oct 2018
👍2

All 5 comments

@yurishkuro I would like to work on this issue.

danehans picture danehans on 11 Jul 2018
🎉1

@danehans go for it! Thanks!

yurishkuro picture yurishkuro on 11 Jul 2018

Hello, is there any plan to release the next version of go-client including https://github.com/jaegertracing/jaeger-client-go/pull/323 ?

Because I've been working on Update HotROD to remove extra flags and almost done.
But the latest version(v2.14.0) of go client doesn't have JAEGER_ENDPOINT.

eundoosong picture eundoosong on 10 Oct 2018

I'll go ahead and cut a new release today.

black-adder picture black-adder on 10 Oct 2018

@eundoosong 2.15 is out

black-adder picture black-adder on 10 Oct 2018
👍2
Was this page helpful?
0 / 5 - 0 ratings

Related issues

Siddhesh-Ghadi picture Siddhesh-Ghadi  路  4Comments
albertteoh picture albertteoh  路  3Comments
saulshanabrook picture saulshanabrook  路  4Comments
mabn picture mabn  路  4Comments
vprithvi picture vprithvi  路  3Comments