Jaeger-operator: Operator doesn't respect priorityClassName for collector or query

[majidazimi]

Jaeger operator doesn't respect setting priorityClassName for collector and query:

apiVersion: jaegertracing.io/v1
kind: Jaeger
metadata:
  name: jaeger
spec:
  strategy: production
  ingress:
    enabled: false
  collector:
    replicas: 1
    options:
      log-level: debug
    resources:
      requests:
        cpu: 100m
        memory: 256Mi
      limits:
        cpu: 300m
        memory: 512Mi
    priorityClassName: system-cluster-critical
  query:
    priorityClassName: system-cluster-critical

Setting above fields doesn't trigger any redeployment. Deleting ReplicaSet manually doesn't create pods with new configuration either. However, Collecotor/Query helm charts already supports this field. Am I missing something or there is really an issue?

[jpkrohling]

Apparently, we have support only for the agent, added as part of https://github.com/jaegertracing/jaeger-operator/pull/1392 . Would you be willing to send a PR adding that to the collector/query?

[majidazimi]

What needs to be changed? I'm not a Go developer. Some hints or guidelines would be great.

[jpkrohling]

You can use the linked PR as a model. The collector/query parts are close to the agent parts, should be easy to spot them. Once you send a PR, I can see if anything else is needed.

[majidazimi]

1413 Please take a look into the changes.

[jpkrohling]

A Go developer couldn't have done better, thanks!