Jaeger-operator: Switch to disable the ingress resource

[secat]

Is it currently possible to disable the creation of the ingress resource?

If not, I think it would be a good feature to update the CRD spec with an ingress configuration section.

[jpkrohling]

Would you like to give it a shot? Should be relatively easy to do.

[secat]

Yes, sure I can implement the feature.

For the switch specification, I was thinking of something like:

apiVersion: io.jaegertracing/v1alpha1
kind: Jaeger
metadata:
  name: my-jaeger
spec:
  ingress:
    enabled: false

What do you think about it?

[jpkrohling]

Right now, the ingress is applied only to the query deployment. So, to avoid any ambiguity, it would be better to have it as a child of the JaegerQuery struct.

[secat]

So it would look like:

apiVersion: io.jaegertracing/v1alpha1
kind: Jaeger
metadata:
  name: my-jaeger
spec:
  query:
    ingress:
      enabled: false

[jpkrohling]

That's my preference, yes.

[secat]

Should I close this issue?

[jpkrohling]

I'm closing. Thanks for the PR!

[sneko]

Hi @secat @jpkrohling, I tried to disable ingress but it doesn't work:

spec:
  strategy: all-in-one
  all-in-one:
    image: jaegertracing/all-in-one:1.7
    options:
      log-level: info
      memory:
        max-traces: 10000
  query:
    ingress:
      enabled: false

Could you help me please? Thanks

[jpkrohling]

@sneko good catch, looks like we need something like this for the all-in-one as well:

https://github.com/jaegertracing/jaeger-operator/blob/e0849b584483716a3565267679146dda0b036a9d/pkg/deployment/query.go#L118-L127

Here:
https://github.com/jaegertracing/jaeger-operator/blob/e0849b584483716a3565267679146dda0b036a9d/pkg/deployment/all-in-one.go#L145-L150

Would you be interested in sending a PR for it?

[jpkrohling]

Created #48 to handle the missing support in the all-in-one.

[sneko]

@jpkrohling to be honest I'm quite busy on other stuff, I was just looking at the operator to see advancement. I'm on my side using for now the Jaeger instance embedded with Istio Helm Chart.

But if I find some spare time I will dig into it (even if I'm not a Go programmer ^^)

BTW, thanks for your work 👍

[jpkrohling]

That's completely understandable! I have a number of other improvements on my queue right now, so, I'll leave it open and see if someone would pick it up as part of hacktoberfest :)

[secat]

@jpkrohling and @sneko I have just submitted PR #49 for this issue.