Jackett: [HD-Torrents] Jackett incorrectly shows 'Freeleech'

[RoloSoze]

Jackett [Freeleech]:

HDT's website [50%]:

There must be more, but that's the only one I found.

[garfield69]

https://github.com/Jackett/Jackett/blob/fa7e808c73cb5f618f0341480dfdd456bb1c7389/src/Jackett.Common/Indexers/HDTorrents.cs#L189-L203
I suspect that the silver/bronze/blue should be adjusting ULVF not DLVF
[Edit] correction, the problem is likely to do with the if then else restructure as the dlvf value assignments are correct as shown in https://github.com/Jackett/Jackett/issues/8197#issuecomment-613760795

[RoloSoze]

Another example:

[RoloSoze]

@ngosang Could this have happened during the recent code cleanup #8089? 'Cause I'm only noticing it now.

[garfield69]

@RoloSoze can you access the web site directly and hover your mouse over the 75 50 and 25 icons and see what the tooltip says these values represent?

[RoloSoze]

25% Count 75% of Download
50% Count 50% of Download
75% Count 25% of Download

Yes, 25% & 75% carry the opposite definition of Jackett's Download Factor

[RoloSoze]

From HDT's FAQ page:

[garfield69]

yes good, that means that my earlier comments about ulvf are irrelevant.
the 8089 code did however restructure the if then else logic, so its likely this is the cause, as the relevant code had been unchanged for 3 year prior to that.

[RoloSoze]

Other than #8089, the only other recent HDT-related ticket is #7734 but I doubt the change made there had anything to do with this issue.

[RoloSoze]

@ngosang @cadatoiva What do y'all think?

[cadatoiva]

8089 doesn't appear to change the layout of the code logic, as all the same assignments are done within the if statements. But just in case, can someone test https://github.com/Jackett/Jackett/releases/tag/v0.14.501 to see if it works correctly?

[garfield69]

Team members with a/c are cadatoiva, ngosang and RoloSoze, so I cant help with testing, sorry.

[cadatoiva]

Oh, 🤦‍♂️I do have an account with this one. I can test it myself

[garfield69]

how handy is that spreadsheet of yours ;-D

[cadatoiva]

I reverted #8089 locally and am getting the same issue.

I'll look into it.

[RoloSoze]

@cadatoiva Haha, you worked on #7734 😂 Just be careful with HDT because if you don’t download at least 15GB every quarter, your account will be disabled.

[cadatoiva]

@RoloSoze thanks for the heads up. Testing this wasn't working without #8089 but running on the latest commit in visual studio and my 16.7 official install is working fine here.

[garfield69]

@RoloSoze double check your Jackett version, what are you on?

[RoloSoze]

0.16.7. I’m always on the latest version.

[garfield69]

what about language, are you using something other than English, does the site even support multi languages?
the code is looking for "Silver Torrent" but yours might be different.
to confirm, on the web site right click over the 50 25 or 75 and select inspect and look for the
Alt= keyword in the img selector

[cadatoiva]

I only see one language option in the settings, so I don't think it's that. Maybe you're account is triggering the global freeleech for some reason?

[cadatoiva]

If you're one of these ranks, your download doesn't count and you have automatic global freeleech.
https://github.com/Jackett/Jackett/blob/fa7e808c73cb5f618f0341480dfdd456bb1c7389/src/Jackett.Common/Indexers/HDTorrents.cs#L25-L33

[RoloSoze]

I’m using English, and it’s not showing me Freeleech for all torrents, so no to Global Freeleech. I can check what @garfield69 asked for later when I get the chance, but for now, could it have something to do with the ‘bumped’ icon (displayed after the discount %)? Notice how both of the examples I posted above are for torrents that have been bumped.

[RoloSoze]

If you're one of these ranks, your download doesn't count and you have automatic global freeleech.

https://github.com/Jackett/Jackett/blob/fa7e808c73cb5f618f0341480dfdd456bb1c7389/src/Jackett.Common/Indexers/HDTorrents.cs#L25-L33

I am not any of these either.

[cadatoiva]

Yup, that's the problem. The Bumped image has alt="Golden Torrent" which is the first check in the list, so it set's the download to 0% counted and then stops.

[garfield69]

its not a problem then, it is working as intended by the web site.

[cadatoiva]

So, here's the situation, according to the site, bumped torrents are ones in danger of having 0 seeds, and are pushed to the top in an effort to give it a boost of downloaders. They might be taking advantage of how our system checks for freeleech to try and boost it with us too (although it would be nice if they communicated that if its the case). It doesn't override the counting system though, so it's not really freeleech.

So I can fix this to the correct numbers by looking for the img src= tag instead, but do we really want to?

[RoloSoze]

its not a problem then, it is working as intended by the web site.

How so? There's nothing in the FAQ that says bumped torrents are freeleech. This is all it says:

So I can fix this to the correct numbers by looking for the img src= tag instead, but do we really want to?

Why wouldn't we? Otherwise, it would be misleading. What am I missing?

[cadatoiva]

Why wouldn't we? Otherwise, it would be misleading. What am I missing?

Because Jackett has no other way to communicate the site's desire to prefer this torrent. This seems like a deliberate choice by the admins to create this behavior.

[RoloSoze]

So I can fix this to the correct numbers by looking for the img src= tag instead,

Wouldn't this fix this issue? If it would, without adversely affecting anything else, I think you should go ahead. Showing 'Freeleech' deceivingly is not right, even if this was the intention.

[garfield69]

IMO, if the site is marking torrents as golden via the alt= tag, but they are not in fact freeleech, and we have the ability to correctly identify the real dlvf and ulvf by using the img src=, then we should do so.
the important factor here it to display the actual cost/benefit to the user of downloading this torrent.
we don't care if the site is bumping the torrent if there is no change to the ratios.

[RoloSoze]

IMO, if the site is marking torrents as golden via the alt= tag, but they are not in fact freeleech, and we have the ability to correctly identify the real dlvf and ulvf by using the img src=, then we should do so.
the important factor here it to display the actual cost/benefit to the user of downloading this torrent.
we don't care if the site is bumping the torrent if there is no change to the ratios.

+1

[cadatoiva]

It would seem I'm out voted. Fixed.

[garfield69]

Jackett 0.16.18

[RoloSoze]

Works well! Thanks!