Jabref: Show proper error message for uncaught exceptions

Created on 19 Nov 2016  路  6Comments  路  Source: JabRef/jabref

JabRef latest version on Win 10

Steps to reproduce:

  1. Add somewhere a throw new NPE() (for example, when showing the AboutDialog)
  2. Perform the action which invokes this code
  3. Nothing happens (e.g. no AboutDialog appears) but also no error message is displayed. (Although an error is logged in the error console.)

With https://github.com/JabRef/jabref/pull/2287 the uncaught error is logged properly, but still no error message is displayed to the user. However, the code in FallbackExceptionHandler can easily be adapted to show a message to the user, see e.g. http://www.javaspecialists.eu/archive/Issue196.html.
As there is an ExceptionDialog for JavaFX, I mark this issue as after-javafx.

good first issue bug 馃悰

All 6 comments

Hi, I'd like to take this one :)

Happy new year! Feel free to work on this issue and also have a look at our contribution guide. Moreover, feel free to drop by in our developer chat if you have questions!

Happy new year as well :+1:

Thanks to @Le-wi this issue should be fixed in the latest master now!

This is so exciting, thanks for tagging beginner issues!

@Le-wi we have to thank you for your help! Looking forward to review the next PR from you ;-)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Siedlerchr picture Siedlerchr  路  4Comments

LinusDietz picture LinusDietz  路  3Comments

oscargus picture oscargus  路  3Comments

thorstenwagner picture thorstenwagner  路  4Comments

tobiasdiez picture tobiasdiez  路  4Comments