Can I use elemental2 jars from maven for it?
You should be able to use them. Either from maven of from the elemental2 github repo. Here is a link to the instructions for projects using bazel.
No it doesn't work yet; needs porting. We have a TODO item for it in spreadsheet.
@gkdn Is this spreadsheet public? Can I take a look at it?
Yeah, @gkdn is right. The spreadsheet is of our internal TODOs but the ones related to open-source J2CL are
If you feel brave and really want to use elemental2, I guess you could hack a version to play with it by modifying the bzl and BUILD files in a similar way to jsinterop-base (commit google/jsinterop-base@503e4422a). YMMV.
Sorry for the confusion.
You can also use the Maven jar and use a j2cl_import bazel rule.
On Sat, Nov 17, 2018, 9:31 AM Roberto Lublinerman <[email protected]
wrote:
Yeah, @gkdn https://github.com/gkdn is right. The spreadsheet is of our
internal TODOs but the ones related to open-source J2CL are
- update elemental2 to work in J2cl (which involves also involves our
internal export tooling)- implement an external version of j2cl_test.
- make sure all tests are passing in the external repo.
If you feel brave and really want to use elemental2, I guess you could
hack a version to play with it by modifying the bzl and BUILD files in a
similar way to jsinterop-base (commit google/jsinterop-base@503e442
https://github.com/google/jsinterop-base/commit/503e4422a). YMMV.Sorry for the confusion.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/google/j2cl/issues/15#issuecomment-439633509, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABDTqfeVo4W7Ss4xXFlvgFt1wNcXBE0Hks5uwEf0gaJpZM4YnQ-b
.
And what about this comment there?
Should only be used for importing annotation byte code, otherwise may result
in hard to debug errors!
Will it really work?
@jDramaix I don't think the maven jar works, since it expects jsinterop-base to work, and at least those published jars don't have the expected js required (goog.requires for properties, native.js for j2cl's impl of JSNI methods)
As a possible workaround, we've opened up our maven repo for external use - we forked jsinterop-base and elemental2 a while back to get them working under j2cl. Downside: these have not quite consistent with the regular published jars and haven't been looked at in a while, so do not match the JsArray.getAny (among a few other calls). To use (at least from maven, probably easier in bazel), be sure to exclude any other copies of elemental2, jsinterop-base.
Repo is at https://repo.vertispan.com/j2cl, look for the com.vertispan.jsinterop and .elemental2 dependencies. These are working when used in https://github.com/vertispan/connected/tree/j2cl and https://github.com/DominoKit/dominodo/tree/j2cl/ (will be updated soon).
For jsinterop-base I suppose you'd rather use the bazel workspace: https://github.com/google/jsinterop-base/commit/503e4422a7f25024df02997f3c60733fe7c0afa9
I tried using them but wasn't able to set it up. Elemental2 isn't compatible with j2cl in one bazel project: https://github.com/google/elemental2/issues/68
Are there any updates on this?
@jDramaix , could you provide an update on the progress?
It's nearly done. The only problem is if you use bazelbuild/rules_closure. Those rules embed their own version of extern files that are not necessarily synced with version used by elemental. We need to modify those rule not to add their externs by default.
Are there any updates? I would be glad to experiment with J2CL and libraries.
Indeed. This seems to be the last little hurdle for me too ;)
Are there any news? I would love to try j2cl, but we use bazel, and I don't want to have maven setup.
We plan to release a version of Elemental2 working with Bazel setup tomorrow.
Please follow the instructions in the elemental2 README: https://github.com/google/elemental2#bazel-dependencies