Ivadomed: Integration of medicaltorch in ivadomed

Created on 13 Apr 2020  路  3Comments  路  Source: ivadomed/ivadomed

Since the fork neuropoly/medicaltorch is starting to differ a lot from the original medicaltorch repository, the fork will be integrated to the ivado-medical-imaging repository. This will centralize the code and avoid to make changes to 2 different repositories.

Different steps for the medicaltorch integration:

  • [x] Merge metrics (dice, recall, specificity, etc.)
  • [x] Integrate filters
  • [ ] Merge transforms. Currently medicaltorch transforms are parent to ivadomed transforms. Moving the transforms will remove this relation. Following class should be moved in ivadomed/transforms.py
    -UndoTransform
    -ToPIL
    -NormalizeInstance
    -NormalizeInstance3D
    -ToTensor
    -StackTensors
    -Crop2D
    -CenterCrop2D
    -ROICrop2D
    -RandomRotation
    -RandomRotation3D
    -RandomReverse3D
    -RandomAffine
    -ElasticTransform
    -Resample
  • [ ] Move following classes in medicaltorch/datasets.py to ivadomed/loader.py
    -SegmentationPair2D
    -MRI2DSegmentationDataset
    -MRI3DSubVolumeSegmentationDataset
    -mt_collate (function)
    -SampleMetadata

The ivadomed/loader.py may become too dense. We might want to create a loader_utils.py.

Most helpful comment

I even wonder if we should create a folder loader with core.py, utils.py, adaptative.py etc.
Similarly a model folder with something like: core.py, unet_2d.py, unet_3d.py, hemis.py, film.py, utils.py. ... one day :)

All 3 comments

The ivadomed/loader.py may become too dense. We might want to create a loader_utils.py.

馃憤 anything that could reduce the code in loader (which is already long) is welcome

I even wonder if we should create a folder loader with core.py, utils.py, adaptative.py etc.
Similarly a model folder with something like: core.py, unet_2d.py, unet_3d.py, hemis.py, film.py, utils.py. ... one day :)

I think we can close this, good job everyone :)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

mariehbourget picture mariehbourget  路  4Comments

vasudev-sharma picture vasudev-sharma  路  5Comments

mariehbourget picture mariehbourget  路  4Comments

charleygros picture charleygros  路  3Comments

copperwiring picture copperwiring  路  4Comments