Istanbul: All stack traces point to line 9
Need
As a developer
I want meaningful stack traces
So that I can quickly debug.
Deliverables
- [ ] Stack traces point to the original line.
Notes
Right now, Istanbul seems to put the entire instrumented code on line 9 so every stack trace will point to line 9 which is not very useful. The first 8 lines seem to be setup code for tracking coverage
A quick win would be to preserve line numbers in the instrumented output. Another way would be to generate source maps.
Thoughts?
NiGhTTraX
All 36 comments
+1 for this. I've been digging through the code to see if it's a setting already, but to no avail.
djak250
on 4 Dec 2014
:+1:
tlhunter
on 15 Feb 2015
This probably needs source maps to do it correctly.
gotwarlost
on 19 Feb 2015
Same here.
Source map support would be awesome, not only to fix this bug.
lo1tuma
on 19 Feb 2015
I have not looked at source maps in any depth but I recall that one of the blockers for source map support is an assumption that istanbul makes when instrumenting the code. Which is that "there is exactly one file being covered". It pulls the coverage object for the file from the global object just once and writes to it.
Having to deal with source maps breaks this assumption because the mapping might point to different files in different parts of the same source (e.g. bundling use cases).
The instrumenter needs to be made more intelligent to handle this case but at the same time the instrumented code should not take a massive performance penalty for the common use case of one source per file.
gotwarlost
on 19 Feb 2015
is there a way to fix this?
ghost
on 14 Mar 2015
+1
agladysh
on 6 Apr 2015
+1
azevedo
on 13 Apr 2015
+1
nayanbhana
on 23 Apr 2015
:+1:
zebateira
on 29 Apr 2015
:+1:
jjvieira
on 29 Apr 2015
:+1:
marcooliveira
on 29 Apr 2015
+1
jladuval
on 29 Apr 2015
:+1:
joanamelo
on 3 May 2015
:+1:
Fdiazreal
on 23 Jul 2015
+1
zanemcca
on 28 Jul 2015
+1
luckscx
on 29 Jul 2015
+1
abobwhite
on 13 Aug 2015
+1
pghalliday
on 15 Sep 2015
This should be labelled as _bug_, not as _enhancement_ (imo :smile:)
seasick
on 22 Oct 2015
I hear you guys. The next version of istanbul will have some support to fix this. I'm in the middle of some surgery so this is not a small addon to the current codebase.
gotwarlost
on 22 Oct 2015
:+1:
9point6
on 26 Nov 2015
+1
ChrisPearce
on 2 Jan 2016
+1
ryan-kimber
on 30 Mar 2016
+1
msholty-fd
on 5 May 2016
+1
andrezero
on 13 Jun 2016
+1
no-chris
on 29 Jun 2016
+1
robertherber
on 4 Jul 2016
+1
darkmavis1980
on 7 Jul 2016
Can we please stop with the +1s? They are pointless and cause spam to those of us who are interested in this issue.
If you want to watch this issue then please use the Subscribe button on the right. If you want just want to +1, then use the reaction that can be found near the bottom of the original post.
MitMaro
on 7 Jul 2016
Yeah ok, but this is an issue open almost 2 years ago and it's rather important
darkmavis1980
on 7 Jul 2016
two and a half years...
henrikrudstrom
on 2 Jan 2017
You should take a look at nyc. It's the new Istanbul command line interface and, from what I can tell, supports sourcemaps.
MitMaro
on 4 Jan 2017
Unfortunately it seems that nyc is waiting for istanbul to support source maps, see issue #231 at nyc
seasick
on 12 Jan 2017
The README mentions source map support and that issue is fairly old and closed. I haven't checked to make sure they are working as expected, but it would be worth a try.
MitMaro
on 12 Jan 2017
Closing this as I've switched to using nyc and it supports source maps.
NiGhTTraX
on 30 Jun 2019
Related issues
asciidisco
路
47Comments
gbahamondezc
路
24Comments
attodorov
路
33Comments
Raynos
路
27Comments
briancullinan
路
22Comments
Most helpful comment
Can we please stop with the +1s? They are pointless and cause spam to those of us who are interested in this issue.
If you want to watch this issue then please use the Subscribe button on the right. If you want just want to +1, then use the reaction that can be found near the bottom of the original post.