Isort: Should recognize dataclasses as standard library

Created on 9 Nov 2018  路  7Comments  路  Source: PyCQA/isort

  • isort 4.3.4
  • Python 3.7.0
isort --diff dataclasses_test.py 
--- dataclasses_test.py:before      2018-11-09 18:38:54.528632
+++ dataclasses_test.py:after       2018-11-09 18:42:54.083710
@@ -2,5 +2,6 @@
 import logging
 import re
 import sys
+from enum import Enum, unique
+
 from dataclasses import dataclass
-from enum import Enum, unique

dataclasses_test.py:
```
import datetime
import logging
import re
import sys
from dataclasses import dataclass
from enum import Enum, unique

Most helpful comment

This was addressed in https://github.com/timothycrosley/isort/commit/4db80bb28ea7f678c20b7d24d6f0574b549a0a1a, but hasn't made it to a release yet.

All 7 comments

This was addressed in https://github.com/timothycrosley/isort/commit/4db80bb28ea7f678c20b7d24d6f0574b549a0a1a, but hasn't made it to a release yet.

Can I help to get this released in some way?

PS. A workaround seems to be to add known_standard_library = dataclasses to your configuration.

As mentioned above, fixed in 4db80bb28ea7f678c20b7d24d6f0574b549a0a1a.

Fixed perhaps, but no release since a year ago.

Sorry, but I don't have PyPI permission to do a release, otherwise I would. That requires @timothycrosley

+1

Just a note a release with this has been pushed out, and @jdufresne has since been giving release permissions as well.

Thanks!

~Timothy

Was this page helpful?
0 / 5 - 0 ratings

Related issues

pawamoy picture pawamoy  路  3Comments

johnthagen picture johnthagen  路  3Comments

akaihola picture akaihola  路  3Comments

whg517 picture whg517  路  3Comments

ionelmc picture ionelmc  路  3Comments