Ipfs-webui: Peers in v2.7.1 no longer get rendered on the map
WebUI on the left: v2.6.0, right: v2.7.1
(tested in empty profile)
I see the same issue in Firefox 70 and Brave 0.70.104
Difference between versions is small (diff), not sure what could cause this, looks like some async code failing silently.
No bandwidth to look into this, but some ideas:
- perhaps bumping
chart.jsto v2.9.3 would help? - code using
p-queue?
lidel
All 10 comments
@hacdias before digging into this, are you able to reproduce?
lidel
on 14 Nov 2019
It seems ipfs-geoip is failing with the newer js-http-client :'( I didn't dig much (will look tomorrow), but upgrading the version of the http client on the redux bundle seems to have broken this.
hacdias
on 14 Nov 2019
@lidel just confirmed and there was a breaking change on v31.0 related to the output of ipfs.object.get and that's what's making this fail. On other news, I can't npm install ipfs-geoip. It just keeps failing and even CI is failing. I will try to get those dependencies updated.
hacdias
on 15 Nov 2019
@hacdias i see #69 is merged, what is the next step on the path to fixing this bug?
lidel
on 24 Nov 2019
@lidel a new release of ipfs-geoip with this change https://github.com/ipfs/ipfs-geoip/commit/37c69135be15ff9d6e31fb4b6cf3a68feccdb01d
hacdias
on 25 Nov 2019
@hacdias https://github.com/ipfs/ipfs-geoip/pull/69 seems to be merged, do you have permissions to publish new version of ipfs-geoip, or do we need to ping someone?
lidel
on 28 Nov 2019
@lidel we definitely need to ping someone: https://www.npmjs.com/package/ipfs-geoip
hacdias
on 28 Nov 2019
/cc @daviddias
hacdias
on 28 Nov 2019
Just gave you access, @hacdias & @lidel
daviddias
on 28 Nov 2019
Thank you!
hacdias
on 28 Nov 2019
Related issues
icf20
路
5Comments
leonprou
路
4Comments
Luflosi
路
3Comments
prettymuchbryce
路
5Comments
daviddias
路
3Comments
Most helpful comment
Just gave you access, @hacdias & @lidel