Ipfs-companion: Regression in HTTP recovery of background tabs

Created on 19 Jun 2020  路  2Comments  路  Source: ipfs/ipfs-companion

If a browser is configured to open links via middle click in the background (without switching active tab), then #876 has unexpected sideeffect:

Fix would be to find tabId that failed and explicitly update using explicit tabIt, instead of assuming it is active.

kinbug help wanted good first issue exnovice P3 statuready efforhours

Most helpful comment

Hi,

I'm able to reproduce the bug and I'm working on it.

All 2 comments

iirc all that needs to be done is request.tabId needs to be passed as the first parameter of every browser.tabs.update call we make in ipfs-request.js

Hi,

I'm able to reproduce the bug and I'm working on it.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

SignpostMarv picture SignpostMarv  路  4Comments

Snawoot picture Snawoot  路  4Comments

samuelmaddock picture samuelmaddock  路  5Comments

skyzyx picture skyzyx  路  3Comments

lidel picture lidel  路  5Comments