Iot: WeatherHelper Pressure functions should return UnitsNet

Created on 14 Sep 2020  路  6Comments  路  Source: dotnet/iot

Describe the bug

In the WeatherHelpers, all the Pressure functions should return UnitsNet. The CalculateAltitude are returning double while they should return Length

Steps to reproduce

see here: https://github.com/dotnet/iot/blob/3c4034781d158b26be0bc4866c34192d86bc4ef1/src/devices/Common/Iot/Device/Common/WeatherHelper.cs#L159

Expected behavior

Return a Length and not a double

Versions used

Source code from latest master baunch.

bug

Most helpful comment

Hi maintainers - I would like to give this a try.

All 6 comments

Hi maintainers - I would like to give this a try.

Sounds great! let us know if you need any help building the repo or submiting your contribution, we are happy to help 馃榾

@cshung not sure if you got anywhere with this, I think @pgrawehr has addressed this as part of other issue

I was planning to do this in October as part of Hacktoberfest.
If it has to be done before October or it is already done somehow then I can let this go, no worries.

This will be fixed with #1178.

As it's now fixed by @pgrawehr , closing this issue!
@cshung we do have quite some other issues open :-D you're welcome to pick another one :-D

Was this page helpful?
0 / 5 - 0 ratings

Related issues

shaggygi picture shaggygi  路  30Comments

shaggygi picture shaggygi  路  22Comments

mpalenov picture mpalenov  路  32Comments

krwq picture krwq  路  34Comments

WoutStandaert picture WoutStandaert  路  19Comments