Ios: New menu

[marinofaggiana]

@immortal79 Ipad pro 11"

[marinofaggiana]

And strange effect with iPhone 11 landscape <> portrait and I think that is better hide the scroolbar in the tableview menu...

[marinofaggiana]

No good with small iPhone 6s iOS 10 (landscape <> portrait), and issue after delete a record with swipe.

@immortal79
Before the PR please try with iPad, old device with iOS 10 and with "Max" device in landscape <> portrait. thx

[marinofaggiana]

iPhone 11 from portrait to landscape

[immortal79]

Will fix ASAP

[marinofaggiana]

@immortal79 look:

the menu must cover the entire surface (window) and the color of background view must be clear (see for example Dropbox)

[immortal79]

Is this what you want or what it looks like in your simulator ?
If this is what you want the view to look like, it's actually a very simple solution to implement and I can do it right now.

Edit: didn't see your edit, I can do this 👍

[marinofaggiana]

Yes, for me this is better (simply) and will adapt to the next bar for iPad with the [+] on center of TabBar

[marinofaggiana]

Is this what you want or what it looks like in your simulator ?
If this is what you want the view to look like, it's actually a very simple solution to implement and I can do it right now.

Edit: didn't see your edit, I can do this 👍

yes, look dropbox

[marinofaggiana]

Whats do you think?

[immortal79]

Ok for me, I start working on it :)

[marinofaggiana]

After https://github.com/nextcloud/ios/pull/1116:

bug : from portrait to landscape with several item is not possible move to te first item ... test it
design : I don't like the margin on safe area ... left right

[marinofaggiana]

@immortal79 it would be nice to add :

[marinofaggiana]

Whats do you think? ( do we do a test? )

[immortal79]

After #1116:

bug : from portrait to landscape with several item is not possible move to te first item ... test it
design : I don't like the margin on safe area ... left right

I can add the top grabber.
But I don't know about the margin I do a test + screenshot and come back to you.

[marinofaggiana]

https://github.com/nextcloud/ios/pull/1118

Great ! What's do you think?

@immortal79 Bug: iPhone open menu in Portrait, move in landscape, with the below gesture for close it, it does not close

[immortal79]

#1119 should fix it

[marinofaggiana]

Bug with iOS 10.3.1 the gesture do not works

[marinofaggiana]

@immortal79 I think that you can replace the other menu sheeeeeet

[marinofaggiana]

BUG: open menu, move with finger a little down and then move up, compare a line white below (dark mode).
BUG: order for size do not works

[immortal79]

Will look into the first bug.
Didn't understand the second one ?

[marinofaggiana]

The menu "order A/Z, Date, size": Order for size do not works :-)

[immortal79]

Oh ok now I get you, will fix that too.

[marinofaggiana]

@immortal79 Bug: Main menu: Open in... crashed

[marinofaggiana]

@immortal79 in AppDelegate.m/ - (void)handleTouchTabbarCenter:(id)sender

UIViewController *vc = _activeMain.splitViewController.viewControllers[0];

now this vc is a NavigationController ... it can be a problem ?