Ioredis: how to catch `connect` error

Created on 9 Jun 2015 · 5Comments · Source: luin/ioredis

https://github.com/luin/ioredis/blob/master/lib/redis/event_handler.js#L76

the default error handler is just noop

Source

haoxins

Most helpful comment

connect always throws when the connection is failed regardless of the value of enableOfflineQueue:

var redis = new Redis({
  host: 'non-exists host',
  lazyConnect: true,
  enableOfflineQueue: false
});
redis.connect().catch(function () {
  console.log('should throw');
});

luin on 9 Jun 2015

👍7

All 5 comments

If enableOfflineQueue is false, should we just throw error when connect failed?

haoxins on 9 Jun 2015

Events could be caught by listening to the specified events of Redis instances. Say you can catch connect errors by listening to error and close. it's just a matter of convenience to return a promise of the connect method for developers to catch connect errors easier.

luin on 9 Jun 2015

connect always throws when the connection is failed regardless of the value of enableOfflineQueue:

var redis = new Redis({
  host: 'non-exists host',
  lazyConnect: true,
  enableOfflineQueue: false
});
redis.connect().catch(function () {
  console.log('should throw');
});

luin on 9 Jun 2015

👍7

:smile: yeah, got it.

haoxins on 9 Jun 2015

Oh my sweet Jesus! I finally got this working...it would not work with all those fancy attributes inside of new Redis(). Kept it simple and it's finally doing what daddy wants!

console.time('Redis')
var Redis = require('ioredis'),
  redis = new Redis()
redis.on('error', err => {
  console.log('REDIS: FAILED')
  process.exit(0)
})
redis.on('connect', () => {
  app.set('redis', redis)
  // continue program logic  
  console.timeEnd('Redis')
})