I saw that the readme suggests using hiredis for better perf but the node binding's version of hiredis is outdated (see https://github.com/redis/hiredis-node/issues/129) and v2 of the js parser seems to be up to speed as well (see https://github.com/luin/ioredis/issues/342) does it still make sense to recommend it?
I would suggest to keep it in the docs but if v2 of the node parser gets merged I see no reason to recommend it anymore.
AdriVanHoudt
All 4 comments
The v2 of the js parser had performance issues when parsing big chunk of data (https://github.com/NodeRedis/node_redis/pull/900#issuecomment-259638072) but it seems this problem has already been fixed. I'll do some benchmarks on it and will switch to it if the performance go better. At that time the recommendation will be definitely removed from the docs.
Thank you for bringing this up!
luin
on 16 Jan 2017
@luin thanks for looking into this!
AdriVanHoudt
on 16 Jan 2017
Closing this since #425 has been merged.
luin
on 26 Jan 2017
Thanks a lot! @luin
AdriVanHoudt
on 26 Jan 2017
Related issues
eduleboss
路
3Comments
pavanratnakar
路
4Comments
PhillipWinder
路
3Comments
hzxuzhonghu
路
5Comments
jehy
路
4Comments
Most helpful comment
The v2 of the js parser had performance issues when parsing big chunk of data (https://github.com/NodeRedis/node_redis/pull/900#issuecomment-259638072) but it seems this problem has already been fixed. I'll do some benchmarks on it and will switch to it if the performance go better. At that time the recommendation will be definitely removed from the docs.
Thank you for bringing this up!