Ionic-framework: bug: ion-button size attribute overwrites round attribute

[oleh-kolinko]

Bug Report

Ionic version:


[x] 4.x

Current behavior:
Not possible to combine attributes shape and size
border-radius is overwritten by .button-small / .button-large class

Expected behavior:
Able to have small/large and rounded buttons

Steps to reproduce:

1. Create simple button

<ion-button>Test</ion-button>

1. Add shape attribute

 <ion-button shape='round'>Test</ion-button>

1. Add size attribute

 <ion-button shape='round' size='small'>Test</ion-button>

Related code:

<!-- shape is round CORRECT -->
<ion-button shape='round'>Test</ion-button>

<!-- shape is not round INCORRECT -->
<ion-button shape='round' size='small'>Test</ion-button>

Other information:

Ionic info:

Ionic:

   ionic (Ionic CLI)             : 4.12.0 (/Users/oleh/.nvm/versions/node/v11.11.0/lib/node_modules/ionic)
   Ionic Framework               : @ionic/angular 4.1.1
   @angular-devkit/build-angular : 0.13.8
   @angular-devkit/schematics    : 7.2.4
   @angular/cli                  : 7.3.5
   @ionic/angular-toolkit        : 1.4.0

Cordova:

   cordova (Cordova CLI) : 8.1.2 ([email protected])
   Cordova Platforms     : none
   Cordova Plugins       : cordova-plugin-ionic 5.3.0, (and 9 other plugins)

System:

   NodeJS : v11.11.0 (/Users/oleh/.nvm/versions/node/v11.11.0/bin/node)
   npm    : 6.9.0
   OS     : macOS Mojave

[brandyscarney]

Thanks for the issue! I am able to reproduce this in ios mode but it seems to be working in md mode. Marking as a bug. 🙂

[ionitron-bot[bot]]

This issue has been labeled as help wanted. This label is added to issues that we believe would be good for contributors.

If you'd like to work on this issue, please comment here letting us know that you would like to submit a pull request for it. This helps us to keep track of the pull request and make sure there isn't duplicated effort.

For a guide on how to create a pull request and test this project locally to see your changes, see our contributing documentation.

Thank you!

[abennouna]

Working on it :)

[ionitron-bot[bot]]

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.