Ionic-framework: Rename interfaces and classes with Prefix (IonInput instead of Input) - @ionic/angular

Created on 1 Dec 2018  路  3Comments  路  Source: ionic-team/ionic-framework

Feature Request

Describe the Feature Request
At the moment the components of Ionic have the interface and class names like "Input" or "Select". Problem is that this interface and class names are used by other packages, "Input" for example by @angular/core.

If you now want to declare variables (for example in ViewChild) it collides with it (see Related Code).

Describe Preferred Solution
I think it would be great if these classes and interfaces get a Prefix like "IonInput" instead of "Input".

Describe Alternatives

Related Code

code_2018-12-01_13-00-27

@ionic/angularcode:

export declare interface Input extends StencilComponents<'IonInput'> {

}
export declare class Input {

}
feature request

Most helpful comment

interesting! i see how this can become a problem! thanks a lot for the feedback, we will review it before RC.

It also seems nice to have a better consistency between Vue, React and Angular, since we are using the Ion prefix there...

But it would be a "breaking change", need to talk with the team!

All 3 comments

interesting! i see how this can become a problem! thanks a lot for the feedback, we will review it before RC.

It also seems nice to have a better consistency between Vue, React and Angular, since we are using the Ion prefix there...

But it would be a "breaking change", need to talk with the team!

I removed [Feature request], since it's more of an API thing, than a feature 馃憤

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

Was this page helpful?
0 / 5 - 0 ratings