Ionic-framework: bug(loadingController): Dismiss throwing exception

[dylanvdmerwe]

Ionic version: (check one with "x")
[ ] 1.x
[ ] 2.x
[x] 3.x

I'm submitting a ... (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/

Current behavior:
When calling dismiss() on a LoadingController, an exception is thrown from the framework.

Expected behavior:
Dismissing popups from the LoadingController should work correctly.

Related code:

  ionViewDidLoad() {
    let loader = this.loader.create({
      content: "Logging out...",
    });
    loader.onDidDismiss(() => {
      console.log('loader dismissed');
    });

    loader.present();

   // perform some quick action

    loader.dismiss();
  }

Other information:

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):

Cordova CLI: 6.5.0
Ionic Framework Version: 3.0.1
Ionic CLI Version: 2.2.2
Ionic App Lib Version: 2.2.1
Ionic App Scripts Version: 1.3.0
ios-deploy version: 1.9.0
ios-sim version: 5.0.10
OS: macOS Sierra
Node Version: v6.9.5
Xcode version: Xcode 8.3.1 Build version 8E1000a

[AmitMY]

I think it is because you can't dismiss something that was not shown.
Try:
loader.present().then(() => loader.dismiss())

[jgw96]

Hey @dylanvdmerwe , @AmitMY makes a good point here, its possible that your running into a race condition here where loader.dismiss() fires before present is done.

PS: Thanks for the input @AmitMY (:

[manucorporat]

Unfortunately, this is in fact a very serious bug and affects all the components using NavControllerBase.

https://github.com/driftyco/ionic/pull/11126#issuecomment-292666442

[mburger81]

@manucorporat What's about this bug?

[mburger81]

News about that?

[AmitMY]

@mburger81 I think its - https://github.com/driftyco/ionic/pull/11128

[mburger81]

@AmitMY yeah thx I saw this some days ago and I also asked to the team a status update about the bug with no response. I don't know how is the situation but I think this bug is really severe and I think this should have max priority or not?

[philipbrack]

Thanks for the lead guys, I found the same issue in my app.

Your system information:

Cordova CLI: 6.5.0
Ionic Framework Version: 3.0.1
Ionic CLI Version: 2.2.2
Ionic App Lib Version: 2.2.1
Ionic App Scripts Version: 1.3.3
ios-deploy version: 1.9.1
ios-sim version: 5.0.8
OS: macOS Sierra
Node Version: v7.7.4
Xcode version: Xcode 8.3.1 Build version 8E1000a

Temporary workaround-

        setTimeout(() => {
          this.loading.dismiss();
        }, 50);

[mburger81]

@AmitMY I'm not sure how this could be a workaround for my issue. I can not do something like that

    ionViewCanEnter(): Promise<any> {
        //console.log('LoginPage#ionViewCanEnter');

        setTimeout(() => {
            return this.authGuard.canActivateLoginPage();
        }, 500);
    }

My problem is for sure the BavControllerBase and I think I have to wait until the team merged and released #11128

[gigocabrera]

@philipbrack your Temporary workaround worked for me too. Thank you

[jgw96]

Hello all! I am going to close this for now as it seems manu's PR to fix this issue was merged. Thanks!

[mburger81]

Okay but which PR do you mean? Just for information?

[ionitron-bot[bot]]

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.