Invidious: Proxy images

[theel0ja]

I understand why you can't proxy videos, but please at least proxy images...

[dimqua]

Not only images, but external CSS and JS also.

[omarroth]

+1. This can be used as a solution for grabbing the highest quality thumbnail for video posters. Because YouTube provides inconsistent thumbnails, it would be nice to say /img/AAAAAAAAAAA.jpg and have Invidious automatically determine the highest it can provide without adding latency to the initial /watch?v=AAAAAAAAAAA request.

CSS and JS also shouldn't be a problem, and will allow some changes necessary for #34 to be tested before they're published upstream.

[omarroth]

As a short update: assets are now hosted locally with 3ec684ae710529f681ea731a3cbd5f6fc9bee6a6.

[omarroth]

Thumbnails are now proxied with 429a4b2deca8b94b04f73fbaf0f50f26c93bac39, it also automagically pulls the highest resolution thumbnail for videos, which is pretty nice. I think the only thing that needs to be proxied now is author thumbs, and we can close this.

[theel0ja]

Great. However, some pages like https://invidio.us/watch?v=yErnuebA9Yo are still downloading some video thumbnails from Google/YouTube.

[theel0ja]

Could it be this line?

https://github.com/omarroth/invidious/blob/429a4b2deca8b94b04f73fbaf0f50f26c93bac39/src/invidious/videos.cr#L670

[omarroth]

Looks like it's still pulling thumbs for related videos. Should be fixed by 3ccee12.

[theel0ja]

Watch pages aren't working anymore. Returns an error.

[omarroth]

What error is it returning?

[theel0ja]

In the title, there was "Error - Invidious". However, it's working now.

[theel0ja]

Fixed 😄 (user photos not yet though)

[theel0ja]

168 for user photos