Intellij: IntelliJ 2021.1 Support

[jameslan]

2021.1 EAP 5 (build 211.6222.4) released on February 25, 2021, and according to https://www.jetbrains.com/idea/nextversion,

the next major update planned for March 2021

Please also consider releasing a newer version to support it.

[AlexeyGy]

2021 stable is out now. We know and will be working on supporting it ASAP.

[ashishgandhi]

Just to be 100% sure, the plugin in the beta channel does not support 2021.1 yet.

[alice-ks]

Just to be 100% sure, the plugin in the beta channel does not support 2021.1 yet.

Indeed. That plugin is for 2020.3.

[steeve]

I asked Florin Pățan from Jetbrains about the maintenance burden of updating the plugin for each release (and thus the lag). He kindly said he would forward it to his colleagues on the SDK team! https://twitter.com/dlsniper/status/1380902984977104899?s=20

Hopefully we can ease the work for all involved!

[sitaktif]

FYI I've got something mostly working - but not complete yet. Specifically:

1. working on the compatibility layer to be backward-compatible till 2020.2
2. some TypeScript apis have changed but I know nothing about it so basically the plugin has undefined behavior with TS.

I'm working on 1. but would be grateful if someone could look at 2. once I have a PR out 😅

[sitaktif]

I opened the PR above - it needs more work before it can be completely merged but I thought that at least it would unblock people who want to start using IJ 2021.1.

[caseyduquettesc]

@sitaktif I made some progress on the test and backwards compat side of things. I pulled in latest master and got these commands working that test and build Intellij CE 2020.3 and 2021.1. Sorry I couldn't help out on the typescript stuff at all

bazel test //:ijwb_ce_tests --define=ij_product=intellij-2021.1
bazel test //:ijwb_ce_tests --define=ij_product=intellij-2020.3

bazel build //ijwb:ijwb_bazel_zip --define=ij_product=intellij-2021.1
bazel build //ijwb:ijwb_bazel_zip --define=ij_product=intellij-2020.3

https://github.com/bazelbuild/intellij/compare/master...caseyduquettesc:casey/intellij-2021.1

[uri-canva]

@caseyduquettesc @sitaktif are you hitting this error when formatting java files?

Got unexpected exception during formatting PsiJavaFile:CachedResolverTest.java

java.util.concurrent.ExecutionException: java.lang.StackOverflowError
    at java.base/java.util.concurrent.FutureTask.report(FutureTask.java:122)
    at java.base/java.util.concurrent.FutureTask.get(FutureTask.java:191)
    at com.intellij.codeInsight.actions.AbstractLayoutCodeProcessor$ProcessingTask.checkStop(AbstractLayoutCodeProcessor.java:408)
    at com.intellij.codeInsight.actions.AbstractLayoutCodeProcessor$ProcessingTask.performFileProcessing(AbstractLayoutCodeProcessor.java:402)
    at com.intellij.codeInsight.actions.AbstractLayoutCodeProcessor$1.run(AbstractLayoutCodeProcessor.java:266)
    at com.intellij.openapi.progress.impl.CoreProgressManager$TaskRunnable.run(CoreProgressManager.java:998)
    at com.intellij.openapi.progress.impl.CoreProgressManager.lambda$runProcessWithProgressAsync$5(CoreProgressManager.java:497)
    at com.intellij.openapi.progress.impl.ProgressRunner.lambda$submit$3(ProgressRunner.java:228)
    at com.intellij.openapi.progress.impl.CoreProgressManager.lambda$runProcess$2(CoreProgressManager.java:178)
    at com.intellij.openapi.progress.impl.CoreProgressManager.registerIndicatorAndRun(CoreProgressManager.java:688)
    at com.intellij.openapi.progress.impl.CoreProgressManager.executeProcessUnderProgress(CoreProgressManager.java:634)
    at com.intellij.openapi.progress.impl.ProgressManagerImpl.executeProcessUnderProgress(ProgressManagerImpl.java:64)
    at com.intellij.openapi.progress.impl.CoreProgressManager.runProcess(CoreProgressManager.java:165)
    at com.intellij.openapi.progress.impl.ProgressRunner.lambda$submit$4(ProgressRunner.java:228)
    at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1700)
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
    at java.base/java.util.concurrent.Executors$PrivilegedThreadFactory$1$1.run(Executors.java:668)
    at java.base/java.util.concurrent.Executors$PrivilegedThreadFactory$1$1.run(Executors.java:665)
    at java.base/java.security.AccessController.doPrivileged(Native Method)
    at java.base/java.util.concurrent.Executors$PrivilegedThreadFactory$1.run(Executors.java:665)
    at java.base/java.lang.Thread.run(Thread.java:834)
Caused by: java.lang.StackOverflowError
    at com.google.idea.blaze.base.formatter.DelegatingCodeStyleManager.getProject(DelegatingCodeStyleManager.java:90)
    at com.google.idea.blaze.base.formatter.ExternalFormatterCodeStyleManager.lambda$getCustomFormatterForFile$0(ExternalFormatterCodeStyleManager.java:60)
    at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:176)
    at java.base/java.util.Spliterators$IteratorSpliterator.tryAdvance(Spliterators.java:1812)
    at java.base/java.util.stream.ReferencePipeline.forEachWithCancel(ReferencePipeline.java:127)
    at java.base/java.util.stream.AbstractPipeline.copyIntoWithCancel(AbstractPipeline.java:502)
    at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:488)
    at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
    at java.base/java.util.stream.FindOps$FindOp.evaluateSequential(FindOps.java:150)
    at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
    at java.base/java.util.stream.ReferencePipeline.findFirst(ReferencePipeline.java:543)
    at com.google.idea.blaze.base.formatter.ExternalFormatterCodeStyleManager.getCustomFormatterForFile(ExternalFormatterCodeStyleManager.java:61)
    at com.google.idea.blaze.base.formatter.ExternalFormatterCodeStyleManager.doReformatText(ExternalFormatterCodeStyleManager.java:79)
    at com.google.idea.sdkcompat.formatter.CodeStyleManagerAdapter.reformatText(CodeStyleManagerAdapter.java:19)
    at com.google.idea.blaze.base.formatter.ExternalFormatterCodeStyleManager.doReformatText(ExternalFormatterCodeStyleManager.java:83)
    at com.google.idea.sdkcompat.formatter.CodeStyleManagerAdapter.reformatText(CodeStyleManagerAdapter.java:19)
    at com.google.idea.blaze.base.formatter.ExternalFormatterCodeStyleManager.doReformatText(ExternalFormatterCodeStyleManager.java:83)
[...]
    at com.google.idea.blaze.base.formatter.ExternalFormatterCodeStyleManager.doReformatText(ExternalFormatterCodeStyleManager.java:83)
    at com.google.idea.sdkcompat.formatter.CodeStyleManagerAdapter.reformatText(CodeStyleManagerAdapter.java:19)

[uri-canva]

It also doesn't seem to automatically attach sources to libraries when navigating to their class files (note source are not eagerly attached to libraries for performance reasons).

[caseyduquettesc]

It also doesn't seem to automatically attach sources to libraries when navigating to their class files (note source are not eagerly attached to libraries for performance reasons).

Yes, I'm seeing the same thing

[mkobit]

Anything to help move this or the open PR forward?

[alice-ks]

We're making good progress regarding 2021.1 for IntelliJ and CLion. The code on the master branch compiles against 2021.1's plugin API and all tests except for the ones for Javascript/Typescript succeed. Implementation wise, we still need to come up with an actual implementation for the new Typescript APIs, which in turn should also fix the test issues. As soon as we have that, we intend to build and push a plugin compatible with 2021.1 to the beta channel of the public plugin repository. This time, we're prioritizing an early beta plugin release over our regular quality procedures which would considerably delay the release. Hence, you might run into more bugs than usual and we'll need your help to test the plugin and file issues.

If you don't want to wait until this release, you can build the plugin yourself via bazel build //ijwb:ijwb_bazel_zip --define=ij_product=intellij-ue-oss-under-dev and install it manually.

By the way, we updated our documentation on https://github.com/bazelbuild/intellij with many more details regarding compatibility contributions. We're grateful for the ones you send us in the past but we couldn't directly integrate them so far. We'd love to change that and hope that the new instructions will be useful for making quick progress regarding the compatibility with 2021.2. That being said, we first need to introduce the 2021.2 plugin API as build reference. So, please wait until this moment before sending compatibility fixes for 2021.2.

[sitaktif]

Thanks a lot for the documentation, it will be super useful to "not super comfortable in there but will give it a stab" kinds of contributors (like myself!) ❤️

[mai93]

We've uploaded a 2021.1-compatible version to the beta channel of the public plugin repository. Add
https://plugins.jetbrains.com/plugins/list?channel=beta to your list of plugin repositories to be able to install and test it.

[yasek]

@mai93 could you please upload a clion version to the beta channel?

[lp55]

@mai93 +1 for a clion version to the beta channel. Without it I can't use this plugin...