Integration: HACS GitHub Action: Don't check whether issues are enabled for forks
Category
- [ ] Backend/Integration
- [ ] Frontend
- [ ] Documentation
- [ ] Bot
- [x] Other
Checklist
- [x] This Feature Request only contains 1 request (if you have multiple open multiple feature requests).
The idea
Don't check whether issues are enabled for forks. If the current repo is a fork, and issues aren't enabled, don't fail.
Implementation
When you ask GitHub whether or not issues are enabled, also check whether it's a fork. If it's a fork, remove the "issues not enabled" message and don't fail.
Alternatives
Just turn it into a warning.
Additional context
KTibow
All 18 comments
Make sure you have read the issue guidelines and that you filled out the entire template.
![hacs-bot[bot] picture](https://avatars1.githubusercontent.com/in/44231?v=4&s=40)
hacs-bot[bot]
on 27 Oct 2020
The action is used for /default
It needs to fail there
ludeeus
on 27 Oct 2020
Could there be an env var to just disable it?
KTibow
on 27 Oct 2020
Yes, but before I change it, I want to convert it to a composite action
ludeeus
on 27 Oct 2020
What do you mean? What would it have?
KTibow
on 27 Oct 2020
ludeeus
on 27 Oct 2020
Takes time to convert...
ludeeus
on 29 Oct 2020
So is there anything stopping this from getting beta tested by people?
KTibow
on 29 Oct 2020
Well, it's only 10% done, so there is that? :smile:
Will probably have converted enough later this week to publish it as a beta action aimed at replacing the current.
ludeeus
on 29 Oct 2020
Sounds good. By the way, you might be able to make any clones quicker with --single-branch, --branch, and --fetch-depth.
KTibow
on 31 Oct 2020
At the point of cloning I don't know the branch, depth I already have for all of them, but sure :+1:
It's not the cloning that takes time, it's running hassfest and HACS load test :smile:
ludeeus
on 31 Oct 2020
The new action does currently not check fork at all, I'll reserve that to the hacs/default repo instead :+1:
https://github.com/marketplace/actions/hacs-action
ludeeus
on 1 Nov 2020
Sounds good! Why would you want to do the requirements check? Python builtins can be very useful.
KTibow
on 1 Nov 2020
Builtins are fine, using 3.party imports that overwrites them, not so much
ludeeus
on 1 Nov 2020
And what exactly does this mean?
✅ This day ends with an 'y' (Sunday)
KTibow
on 1 Nov 2020
That this day ends with the character 'y'
ludeeus
on 1 Nov 2020
Why does it check for that?
KTibow
on 1 Nov 2020
1) It does not check
2) For fun
ludeeus
on 1 Nov 2020
Related issues
rpitera
·
7Comments
astrandb
·
3Comments
InePetrine
·
8Comments
dkagedal
·
5Comments
SeanPM5
·
6Comments
Most helpful comment
Well, it's only 10% done, so there is that? :smile:
Will probably have converted enough later this week to publish it as a beta action aimed at replacing the current.