Instantsearch.js: RefinementList: Avoid showMore for show nothing

Created on 17 Oct 2016  路  9Comments  路  Source: algolia/instantsearch.js

Bug

Most helpful comment

@bobylito yes. One option could be add a disabled class under count < limitMin

All 9 comments

Thanks, this is a bug (want to fix it? :D)

@vvo I wanna, but I actually don't know how to setup react-instantsearch on local with live-compile for fix this

yes, but I mean, in my code I have require('react-instantsearch').

Could be possible have a local copy of react-instantsearch and compile it every time that I make a change to be how the changes affect to my code?

@Kikobeats Not so easy to do, easiest would be to use our dev environement, take any live example and fix it from there (or use npm run dev, it's a live reload jest unit test env).

We currently do not have an npm run build:watch so maybe that's what you would require? So that you could just:

  • clone v2 branch of instantsearch.js
  • yarn
  • npm link
  • npm run build:watch

Then in your project:

  • npm link react-instantsearch

Would that work for you?

What should be the behavior? I was thinking that if I activated the option I would maybe not get that why the button would disappear. Maybe instead of hiding the button, we should disable it when item count < limitMin?

@bobylito yes. One option could be add a disabled class under count < limitMin

Looks good as a solution

Moved to #1455

Was this page helpful?
0 / 5 - 0 ratings