Instantsearch.js: Input typed "search" instead of "text"?

Created on 22 Jun 2016  路  6Comments  路  Source: algolia/instantsearch.js

Would it make sense to use a search input instead of text input for the search box widget?

All 6 comments

When you say "The searchbox widget", you mean the DocSearch input ?

I don't think it would be necessary, since it's already working fine and without any problems, using all the needed components ( the search icon, the clear icon ).

Also, it would imply that we would have to work more on the style of the input, to make it looks the same everywhere, and to ditch it's "built-in" components ( search icon, clear icon ) in order to akeep ours.

If we would have to change it, I guess we would proceed like the following :

  • Set the input to type=search
  • Remove it's browser styles
  • Overwrite the built-in components with our components ( search and clear icon )

And it seems overkill to me. But that's just my point.

Plus, I took the liberty to screenshot this slide of @Shipow presentation about Searchbox.

What do you guys think about it ?

By search box widget I mean the search box widget of the instant search lib.
But yes I suppose if we use search type, it will require additional css work. But at the same time it is pretty convenient to have the reset icon.

@rayrutjes We are planning on redoing the searchBox, and that would include all the nice things like clear and search icons. see https://github.com/algolia/instantsearch.js/issues/1060

As said by @LukyVj, we won't use the type="search" if that requires a lot of extra work to style it, we will see

LGTM!

Ok, i'll schedule up the presentation internally. There are things everyone needs to know.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

object505 picture object505  路  4Comments

bobylito picture bobylito  路  3Comments

bobylito picture bobylito  路  3Comments

egyprotech picture egyprotech  路  3Comments

Spone picture Spone  路  3Comments