Ink: [v2] re-rendering devours previous lines?
This only seems to happen on Hyper for me, when using tmux with a log line and not all the time, but I managed to get a recording of it, and my npm pick-updates npm branch seems to reproduce it for me fairly often.
Repro Steps
- Get Hyper and tmux
git clone https://github.com/npm/cli && cd climake linknpm pick-updates- Move your cursor around.
Results
zkat
All 7 comments
Didn't see that before, will check it out today!
vadimdemedes
on 20 Feb 2019
Reproduced this after resizing Hyper, it seems Hyper doesn't wrap terminal output correctly as you resize the window.
vadimdemedes
on 21 Feb 2019
I was unable to fix it yet, but I do have some ideas that I'll try out tomorrow.
vadimdemedes
on 21 Feb 2019
It seems I'll have to implement own wrapping of terminal output. I've tried wrap-ansi and terminal-kit, but no luck. If you know of any other packages that wrap output while handling ANSI escapes, please send me a link!
vadimdemedes
on 22 Feb 2019
After implementing 3 different functions for wrapping terminal output, I decided to try to patch wrap-ansi itself: https://github.com/chalk/wrap-ansi/pull/29. It still has one issue left to fix, but I thought it would be useful to give you an update and a way to track progress of this issue.
vadimdemedes
on 24 Feb 2019
Thanks a lot for looking into this! Hopefully they'll land your patch soon 馃挌
zkat
on 25 Feb 2019
Fixed in 2.0.0-17!
vadimdemedes
on 4 Mar 2019
Related issues
treshugart
路
4Comments
danikaze
路
5Comments
colinking
路
6Comments
sindresorhus
路
7Comments
cometkim
路
3Comments
Most helpful comment
After implementing 3 different functions for wrapping terminal output, I decided to try to patch
wrap-ansiitself: https://github.com/chalk/wrap-ansi/pull/29. It still has one issue left to fix, but I thought it would be useful to give you an update and a way to track progress of this issue.