Ingress-nginx: Too many nginx reloads

[yuyang0]

NGINX Ingress controller version: 0.17.1

Kubernetes version (use kubectl version): 1.10.5

every time when an Ingress is changed, it will trigger two nginx reloads. According to my debug, it is caused by cert-related issue. when an ingress is updated, a new SSLcert is generated In store.SyncSecrets, but it doesn't assign a value to FullChainPemFileName, so syncIngress will trigger the first reload, when the checkSSLChainIssues generate the CA certification chain later, it will assign value to FullChainPemFileName , it will trigger second nginx reload. I'm not very familiar with this codebase, so I don't know the best way to fix this problem

[hnrytrn]

Hey Yu Yang, I'm currently working on a feature that will fix this issue by serving certificates dynamically instead of reloading NGINX. I should have a PR for this up sometime this week.

[yuyang0]

@hnrytrn I don't think #2889 has fixed this problem. this PR only adds a lua library,but it should also adjust the code in IsDynamicConfigurationEnough and configureDynamically.

[hnrytrn]

There are 2 other related PRs that I will be adding, and one of them will be adjusting code in IsDynamicConfigurationEnough and configureDynamically.