Influxdb: Debug level logging dumps user session key

[desa]

In a number of places in the codebase we print the users session key in debug level logs.

https://github.com/influxdata/influxdb/blob/master/http/check_service.go#L237

This happens in a number of different places. Ideally, we should not dump the HTTP request as is done there. At the very least, we should be scrubbing any potentially sensitive data.

[jsteenb2]

@jademcgough and @desa feels like we could just drop these debug logs. Is there some background on why they were added originally?

[desa]

Seems like we could drop them to me

On Tue, Sep 24, 2019 at 8:18 PM Johnny Steenbergen [e-mail]
wrote:

@jademcgough https://github.com/jademcgough and @desa
https://github.com/desa feels like we could just drop these debug logs.
Is there some background on why they were added originally?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/influxdata/influxdb/issues/15258?email_source=notifications&email_token=AALIXI5DK3Z32WQJHEG5UKDQLKU6VA5CNFSM4I2D5II2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7QFXIA#issuecomment-534797216,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALIXI3HU743GWZ25QUOTNLQLKU6VANCNFSM4I2D5IIQ
.

[immykins]

I think the idea was to provide a paper trail for requests / user actions.

If we do want to filter out sensitive data:

• headers contain auth tokens
• so do responses from auth creation
• notification endpoints are created with security keys
• /onboarding returns a token
• /users/:id/password is logging the password

If no one cares, I'm in favor of just removing the http debug logs.

[desa]

Good points. They can definitely be useful for debugging. I think we should
just scrub the logs of sensitive data.

On Tue, Sep 24, 2019 at 9:37 PM Jade McGough [e-mail]
wrote:

I think the idea was to provide a paper trail for requests / user actions.

If we do want to filter out sensitive data:

• headers contain auth tokens
• so do responses from auth creation
• notification endpoints are created with security keys
• /onboarding returns a token
• /users/:id/password is logging the password

If no one cares, we can just drop the debug logs in the http layer.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/influxdata/influxdb/issues/15258?email_source=notifications&email_token=AALIXI6DARGAYZDT2U57LXLQLK6FLA5CNFSM4I2D5II2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7QJVKA#issuecomment-534813352,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALIXI5VDYXLTQPXK67FVADQLK6FLANCNFSM4I2D5IIQ
.