React-redux 5 was just released with a new API and also a new way of handling subscriptions, which according to them can in some cases vastly improve performance. There is also a new connectAdvanced API which connect is built on. Should this maybe be ported?
[Update]
That being said, if there is interest in this being done, I am willing to attempt the porting myself and can make a PR.
Alxandr
All 9 comments
@Alxandr sounds great if you feel like you'd like to port over? We already have an inferno-redux which you could use as a guidebook for some of the ways we've ported things. A few things to mention (unless these have changed in version 5): you'll have to remove string refs and make them callback refs, you'll have to change usage of findDOMNode and if Redux still uses createClass, you'll need to make it Component.
trueadm
on 15 Dec 2016
I'll get on it :). I doubt they still use string refs as they've been deprecated in react for a while afaik. I'll try to blatantly steal their tests as well if applicable :)
Alxandr
on 15 Dec 2016
@Alxandr just following up on this issue, wondering if you had a chance to dive into this at all?
davedbase
on 26 Dec 2016
If this gets dropped by the time I return home from the holidays I'll pick it up but that'll be a few days
durango
on 26 Dec 2016
@ddibiase, @durango most of it's already done. All the code is ported except for tests. I've had some problems with tests (most of it discussed on slack) but I think that has been resolved by now. Problem is that it's christmas and I have a bunch of family parties to attend, but I try to get in time to work on it whenever I can.
Alxandr
on 26 Dec 2016
@Alxandr that sounds awesome, and thank you for taking the time in doing the work :+1: Family comes first, we can wait, just don't forget about us ;)
durango
on 26 Dec 2016
any news?
buzinas
on 6 Feb 2017
No, sorry, I've been busy lately. Most of it is working I believe (not all tests are ported), but last I worked on it there was a large issue with tslint errors on the inferno repo (which I've been told has been fixed by now though). See https://github.com/infernojs/inferno/pull/638 for last updates.
Alxandr
on 6 Feb 2017
I'm pretty sure I've merged this now.
LukeSheard
on 10 Jul 2017
Related issues
Havunen
路
3Comments
yury-dymov
路
5Comments
jdalton
路
3Comments
alexichepura
路
5Comments
highhi
路
4Comments
Most helpful comment
I'll get on it :). I doubt they still use string refs as they've been deprecated in react for a while afaik. I'll try to blatantly steal their tests as well if applicable :)