Infection: What are the lowest supported versions of each test framework that infection supports?

Created on 27 Feb 2018  路  6Comments  路  Source: infection/infection

TODO:

  • [ ] Find out exactly what the lowsest versions are of each supported test framework
  • [ ] Add documentation for that on https://github.com/infection/site
  • [ ] Add an e2e test that requires the use of that version, so we know if we no longer support that version
  • [ ] Add a constraint to composer.json
Good First Issue / Easy Pick Help Wanted

Most helpful comment

I mean something like this. It's not a good example because it should prevent Symfony 5. But when you install Infection as a library it will prevent you to be able to install it if you have the wrong versions

All 6 comments

The lowest versions I worked with using infection are:

  • PHPUnit 5.5.7
  • phpspec 3.4.0

But I don't know exactly the minimum ones

We also should have a conflict rule in the composer.json for it. It won't help with the PHAR (yet at least) but still worth it IMO :)

@theofidry I'm sorry i dont follow what you mean

I mean something like this. It's not a good example because it should prevent Symfony 5. But when you install Infection as a library it will prevent you to be able to install it if you have the wrong versions

lowest version for the different versions of php interpreter will be different. For example phpUnit < 6 and with php 7.2 will throw Fatal error:

PHP Fatal error:  Declaration of SebastianBergmann\Comparator\DOMNodeComparator::assertEquals($expected, $actual, $delta = 0, $canonicalize = false, $ignoreCase = false) must be compatible with SebastianBergmann\Comparator\ObjectComparator::assertEquals($expected, $actual, $delta = 0, $canonicalize = false, $ignoreCase = false, array &$processed = Array) in phar:///var/www/infection/phpunit-5.7.9.phar/sebastian-comparator/DOMNodeComparator.php on line 110
PHP Stack trace:
PHP   1. {main}() /var/www/infection/phpunit-5.7.9.phar:0

Fatal error: Declaration of SebastianBergmann\Comparator\DOMNodeComparator::assertEquals($expected, $actual, $delta = 0, $canonicalize = false, $ignoreCase = false) must be compatible with SebastianBergmann\Comparator\ObjectComparator::assertEquals($expected, $actual, $delta = 0, $canonicalize = false, $ignoreCase = false, array &$processed = Array) in phar:///var/www/infection/phpunit-5.7.9.phar/sebastian-comparator/DOMNodeComparator.php on line 110

Call Stack:
    0.0068     869280   1. {main}() /var/www/infection/phpunit-5.7.9.phar:0

right now I don't see a better way than mark phpUnit < 6.0 as conflicted

I'd say if the constraint is due to php versions its not a problem for us. But if for example we use options that were not introduced before a certain phpunit version. We should notify the end users

Was this page helpful?
0 / 5 - 0 ratings

Related issues

zdenekgebauer picture zdenekgebauer  路  8Comments

majkel89 picture majkel89  路  7Comments

sanmai picture sanmai  路  5Comments

maks-rafalko picture maks-rafalko  路  3Comments

maks-rafalko picture maks-rafalko  路  4Comments