Inertia: Inline nprogress css

Created on 16 Apr 2019  路  5Comments  路  Source: inertiajs/inertia

While Inertia uses nprogress by default for showing page load progress, it doesn't actually include any CSS for it. You are still required to include this on your own (example).

It would be nice to simply inline this somehow. It would be wise to review how Turbolinks does this, since their CSS is mega simple.

Most helpful comment

While that approach would certainly be the easiest, I don't think it's the best from a DX perspective. I think we need to ship with something.

All 5 comments

I'm thinking it makes sense to just create our own progress bar. We can go off Turbolinks implementation for this.

I don't think Inertia should integrate a progress bar. A hook system, before and after the visit should be implemented in order to let the user deploys his own progress bar (with a sample example in the documentation). For example, in my project, I don't use the Inertia progress bar, but only indicators based on the promise returned by the Inertia.visit() method. It should be great if a hook can be applied globally and manages my own progress bar, without having a progress bar dependencies I don't use.

While that approach would certainly be the easiest, I don't think it's the best from a DX perspective. I think we need to ship with something.

With a full documentation about how to register nprogress with hooks, it could be easy to set up ?

This has been done, but in the https://github.com/inertiajs/progress package. 馃憤

Was this page helpful?
0 / 5 - 0 ratings

Related issues

MichaelDeBoey picture MichaelDeBoey  路  4Comments

kirrg001 picture kirrg001  路  6Comments

reinink picture reinink  路  3Comments

sebastiandedeyne picture sebastiandedeyne  路  6Comments

sebastiandedeyne picture sebastiandedeyne  路  3Comments