Incubator-superset: Adding annotation formula to bar chart add more bars instead of line

[kristw]

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Go to explore
2. Create time-series bar chart
3. Add annotation layer
4. Set y=constant e.g. y=100 as formula

Expected behavior
A horizontal line at y 100

Screenshots
It adds a bar for each grouped bar instead.

Environment (please complete the following information):

• superset-ui version: current

[junlincc]

this issue is duplicate here and already being fixed (sort of, as bar chart does not support this annotation), waiting for your reviews~ @kristw

if this is important to your users, I can open an enhancement issue separately

[junlincc]

@kristw

issue is resolved by https://github.com/apache/incubator-superset/pull/11876
additional enhancement will come later.

[kristw]

@graceguo-supercat Please correct me if I misunderstood since you report the issue, but I thought the bar chart support this previously and this is a regression?

If the bar chart did not support this before then please re-close the ticket.

[graceguo-supercat]

@kristw No, i am not sure this is a regression. This is probably just a bug for a long time but no one reported before.

[junlincc]

@agatapst confirmed that line formula annotation was not supported in the past. @kristw do you mind opening an enhancement issue and close this one?

[kristw]

sgtm then. Thank you all.

[junlincc]

@kristw @graceguo-supercat try Echarts time series bar chart, it does support formula annotation line. does it work for you user cases?