Incubator-superset: Follow up on ace library fix to fix Markdown with Emoji issue

Created on 29 Oct 2020  路  8Comments  路  Source: apache/incubator-superset

As per conclusion in this bug https://github.com/apache/incubator-superset/issues/11331 this enhancement request is just a reminder to wait for a fix in the Ace Editor and validate it fully fixes the bug with Shifting cursor (forward) when editing Markdown with emoji.

request

Most helpful comment

@kkucharc asked in Ace editor issue about any news in that. Upgrading react-ace to 9.2.0 didn鈥檛 help.

added Markdown component to roadmap inbox
https://github.com/apache-superset/superset-roadmap/projects/1

All 8 comments

Issue-Label Bot is automatically applying the label #enhancement to this issue, with a confidence of 0.83. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

Have we opened an issue with https://github.com/ajaxorg/ace?

I haven't. @kkucharc have you / if not could you please open one since you discovered issue is with that?

Did we check that we're on the latest Ace, sometimes bumping to latest version addresses little bugs like this one?

@mistercrunch yes, it appears it's broken in their demo too (as per https://github.com/apache/incubator-superset/issues/11331)

Gotcha. I just looked and our react-ace is super behind though. It moved from being based on brace to something new ace-builds.

@kkucharc asked in Ace editor issue about any news in that. Upgrading react-ace to 9.2.0 didn鈥檛 help.

added Markdown component to roadmap inbox
https://github.com/apache-superset/superset-roadmap/projects/1

I asked in this issue about any news in the topic: https://github.com/ajaxorg/ace/issues/4142

Was this page helpful?
0 / 5 - 0 ratings

Related issues

XiaodiKong picture XiaodiKong  路  3Comments

eliab picture eliab  路  3Comments

deity-bram picture deity-bram  路  3Comments

john-bodley picture john-bodley  路  3Comments

lenguyenthedat picture lenguyenthedat  路  3Comments